Fixing #1402 (#1898)

KKhurin · web-flow · commit c975ecc23994 · 2017-05-10T11:31:12.000-07:00
Fixing #1402 Enabling session tests Exposing OperationContext.GetCallbackChannel in the contract Addressing feedback about wrapping timer callback
diff --git a/src/System.Private.ServiceModel/src/Internals/System/Runtime/Fx.cs b/src/System.Private.ServiceModel/src/Internals/System/Runtime/Fx.cs
@@ -288,6 +288,11 @@ public static AsyncCallback ThunkCallback(AsyncCallback callback)
             return (new AsyncThunk(callback)).ThunkFrame;
         }
 
+        public static Action<T1> ThunkCallback<T1>(Action<T1> callback)
+        {
+            return (new ActionThunk<T1>(callback)).ThunkFrame;
+        }
+
         [SuppressMessage(FxCop.Category.ReliabilityBasic, FxCop.Rule.UseNewGuidHelperRule,
             Justification = "These are the core methods that should be used for all other Guid(string) calls.")]
         public static Guid CreateGuid(string guidString)
diff --git a/src/System.Private.ServiceModel/src/Resources/Strings.resx b/src/System.Private.ServiceModel/src/Resources/Strings.resx
@@ -1950,4 +1950,10 @@
   <data name="SFxInvalidSoapAttribute" xml:space="preserve">
     <value>XmlSerializer attribute {0} is not valid in {1}. Only SoapElement attribute is supported.</value>
   </data>
+  <data name="SFxTerminatingOperationAlreadyCalled1" xml:space="preserve">
+    <value>This channel cannot send any more messages because IsTerminating operation '{0}' has already been called. </value>
+  </data>
+  <data name="SFxChannelTerminated0" xml:space="preserve">
+    <value>An operation marked as IsTerminating has already been invoked on this channel, causing the channel's connection to terminate.  No more operations may be invoked on this channel.  Please re-create the channel to continue communication.</value>
+  </data>
 </root>
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Channels/ServiceChannel.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Channels/ServiceChannel.cs
@@ -47,6 +47,7 @@ internal sealed class ServiceChannel : CommunicationObject, IChannel, IClientCha
         private readonly bool _openBinder = false;
         private TimeSpan _operationTimeout;
         private object _proxy;
+        private string _terminatingOperationName;
         private bool _hasChannelStartedAutoClosing;
         private bool _hasCleanedUpChannelCollections;
         private EventTraceActivity _eventActivity;
@@ -566,6 +567,11 @@ private void PrepareCall(ProxyOperationRuntime operation, bool oneway, ref Proxy
                 throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new InvalidOperationException(SR.Format(SR.SFxNonInitiatingOperation1, operation.Name)));
             }
 
+            if (_terminatingOperationName != null)
+            {
+                throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new InvalidOperationException(SR.Format(SR.SFxTerminatingOperationAlreadyCalled1, _terminatingOperationName)));
+            }
+
             if (_hasChannelStartedAutoClosing)
             {
                 throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new ProtocolException(SR.SFxClientOutputSessionAutoClosed));
@@ -934,6 +940,7 @@ private void HandleReply(ProxyOperationRuntime operation, ref ProxyRpc rpc)
                                                                                   operation.Name,
                                                                                   rpc.Reply.Headers.Action,
                                                                                   operation.ReplyAction));
+                            TerminateIfNecessary(ref rpc);
                             throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(error);
                         }
                     }
@@ -947,6 +954,7 @@ private void HandleReply(ProxyOperationRuntime operation, ref ProxyRpc rpc)
                         }
                         ThrowIfFaultUnderstood(rpc.Reply, fault, action, rpc.Reply.Version, rpc.Channel.GetProperty<FaultConverter>());
                         FaultException fe = rpc.Operation.FaultFormatter.Deserialize(fault, action);
+                        TerminateIfNecessary(ref rpc);
                         throw DiagnosticUtility.ExceptionUtility.ThrowHelperWarning(fe);
                     }
 
@@ -982,6 +990,7 @@ private void HandleReply(ProxyOperationRuntime operation, ref ProxyRpc rpc)
                     }
                 }
             }
+            TerminateIfNecessary(ref rpc);
 
             if (WcfEventSource.Instance.ServiceChannelCallStopIsEnabled())
             {
@@ -996,6 +1005,15 @@ private void HandleReply(ProxyOperationRuntime operation, ref ProxyRpc rpc)
             }
         }
 
+        private void TerminateIfNecessary(ref ProxyRpc rpc)
+        {
+            if (rpc.Operation.IsTerminating)
+            {
+                _terminatingOperationName = rpc.Operation.Name;
+                TerminatingOperationBehavior.AfterReply(ref rpc);
+            }
+        }
+
         private void ThrowIfFaultUnderstood(Message reply, MessageFault fault, string action, MessageVersion version, FaultConverter faultConverter)
         {
             Exception exception;
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Description/ContractDescription.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Description/ContractDescription.cs
@@ -228,7 +228,7 @@ internal void EnsureInvariants()
                 operationDescription.EnsureInvariants();
                 if (operationDescription.IsInitiating)
                     thereIsAtLeastOneInitiatingOperation = true;
-                if ((!operationDescription.IsInitiating)
+                if ((!operationDescription.IsInitiating || operationDescription.IsTerminating)
                     && (this.SessionMode != SessionMode.Required))
                 {
                     throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new InvalidOperationException(
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Description/DispatcherBuilder.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Description/DispatcherBuilder.cs
@@ -134,6 +134,7 @@ private static void BuildProxyOperation(OperationDescription operation, ClientRu
             child.EndMethod = operation.EndMethod;
             child.IsOneWay = operation.IsOneWay;
             child.IsInitiating = operation.IsInitiating;
+            child.IsTerminating = operation.IsTerminating;
             child.IsSessionOpenNotificationEnabled = operation.IsSessionOpenNotificationEnabled;
             for (int i = 0; i < operation.Faults.Count; i++)
             {
@@ -160,6 +161,7 @@ private static void BuildDispatchOperation(OperationDescription operation, Dispa
 
             child.HasNoDisposableParameters = operation.HasNoDisposableParameters;
 
+            child.IsTerminating = operation.IsTerminating;
             child.IsSessionOpenNotificationEnabled = operation.IsSessionOpenNotificationEnabled;
             for (int i = 0; i < operation.Faults.Count; i++)
             {
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Description/OperationDescription.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Description/OperationDescription.cs
@@ -11,13 +11,14 @@
 
 namespace System.ServiceModel.Description
 {
-    [DebuggerDisplay("Name={_name}, IsInitiating={_isInitiating}")]
+    [DebuggerDisplay("Name={_name}, IsInitiating={_isInitiating}, IsTerminating={_isTerminating}")]
     public class OperationDescription
     {
         internal const string SessionOpenedAction = Channels.WebSocketTransportSettings.ConnectionOpenedAction;
 
         private XmlName _name;
         private bool _isInitiating;
+        private bool _isTerminating;
         private bool _isSessionOpenNotificationEnabled;
         private ContractDescription _declaringContract;
         private FaultDescriptionCollection _faults;
@@ -49,6 +50,7 @@ public OperationDescription(string name, ContractDescription declaringContract)
             }
             _declaringContract = declaringContract;
             _isInitiating = true;
+            _isTerminating = false;
             _faults = new FaultDescriptionCollection();
             _messages = new MessageDescriptionCollection();
             _behaviors = new KeyedByTypeCollection<IOperationBehavior>();
@@ -164,6 +166,12 @@ internal bool IsServerInitiated()
             return Messages[0].Direction == MessageDirection.Output;
         }
 
+        public bool IsTerminating
+        {
+            get { return _isTerminating; }
+            set { _isTerminating = value; }
+        }
+
         public Collection<Type> KnownTypes
         {
             get { return _knownTypes; }
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Description/TypeLoader.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Description/TypeLoader.cs
@@ -954,6 +954,8 @@ private OperationDescription CreateOperationDescription(ContractDescription cont
 
             OperationDescription operationDescription = new OperationDescription(operationName.EncodedName, declaringContract);
             operationDescription.IsInitiating = opAttr.IsInitiating;
+            operationDescription.IsTerminating = opAttr.IsTerminating;
+
             operationDescription.IsSessionOpenNotificationEnabled = opAttr.IsSessionOpenNotificationEnabled;
 
             operationDescription.HasNoDisposableParameters = ServiceReflector.HasNoDisposableParameters(methodInfo);
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/ChannelHandler.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/ChannelHandler.cs
@@ -42,6 +42,7 @@ internal class ChannelHandler
         private bool _hasRegisterBeenCalled;
         private bool _hasSession;
         private int _isPumpAcquired;
+        private bool _isChannelTerminated;
         private bool _isConcurrent;
         private bool _isManualAddressing;
         private MessageVersion _messageVersion;
@@ -279,6 +280,11 @@ private bool DispatchAndReleasePump(RequestContext request, bool cleanThread, Op
                     MessageLogger.LogMessage(ref message, (operation.IsOneWay ? MessageLoggingSource.ServiceLevelReceiveDatagram : MessageLoggingSource.ServiceLevelReceiveRequest) | MessageLoggingSource.LastChance);
                 }
 
+                if (operation.IsTerminating && _hasSession)
+                {
+                    _isChannelTerminated = true;
+                }
+
                 bool hasOperationContextBeenSet;
                 if (currentOperationContext != null)
                 {
@@ -694,6 +700,14 @@ private bool HandleRequest(RequestContext request, OperationContext currentOpera
                     this.ReleasePump();
                     return true;
                 }
+
+                if (_isChannelTerminated)
+                {
+                    ReleasePump();
+                    ReplyChannelTerminated(request);
+                    return true;
+                }
+
                 if (_requestInfo.RequestContext != null)
                 {
                     Fx.Assert("ChannelHandler.HandleRequest: this.requestInfo.RequestContext != null");
@@ -851,6 +865,16 @@ private void ReplyContractFilterDidNotMatch(RequestContext request)
             }
         }
 
+        private void ReplyChannelTerminated(RequestContext request)
+        {
+            FaultCode code = FaultCode.CreateSenderFaultCode(FaultCodeConstants.Codes.SessionTerminated,
+                FaultCodeConstants.Namespaces.NetDispatch);
+            string reason = SR.Format(SR.SFxChannelTerminated0);
+            string action = FaultCodeConstants.Actions.NetDispatcher;
+            Message fault = Message.CreateMessage(_messageVersion, code, reason, action);
+            ReplyFailure(request, fault, action, reason, code);
+        }
+
         private void ReplyFailure(RequestContext request, FaultCode code, string reason)
         {
             string action = _messageVersion.Addressing.DefaultFaultAction;
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/ClientOperation.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/ClientOperation.cs
@@ -37,6 +37,7 @@ public sealed class ClientOperation : ClientOperationCompatBase
         private IClientFaultFormatter _faultFormatter;
         private bool _isInitiating = true;
         private bool _isOneWay;
+        private bool _isTerminating;
         private bool _isSessionOpenNotificationEnabled;
         private string _name;
 
@@ -194,6 +195,19 @@ public bool IsOneWay
             }
         }
 
+        public bool IsTerminating
+        {
+            get { return _isTerminating; }
+            set
+            {
+                lock (_parent.ThisLock)
+                {
+                    _parent.InvalidateRuntime();
+                    _isTerminating = value;
+                }
+            }
+        }
+
         public string Name
         {
             get { return _name; }
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/DispatchOperation.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/DispatchOperation.cs
@@ -14,6 +14,7 @@ public sealed class DispatchOperation
         private IDispatchMessageFormatter _formatter;
         private IDispatchFaultFormatter _faultFormatter;
         private IOperationInvoker _invoker;
+        private bool _isTerminating;
         private bool _isSessionOpenNotificationEnabled;
         private readonly string _name;
         private readonly SynchronizedCollection<IParameterInspector> _parameterInspectors;
@@ -148,6 +149,19 @@ public IOperationInvoker Invoker
             }
         }
 
+        public bool IsTerminating
+        {
+            get { return _isTerminating; }
+            set
+            {
+                lock (_parent.ThisLock)
+                {
+                    _parent.InvalidateRuntime();
+                    _isTerminating = value;
+                }
+            }
+        }
+
         internal bool IsSessionOpenNotificationEnabled
         {
             get { return _isSessionOpenNotificationEnabled; }
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/DispatchOperationRuntime.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/DispatchOperationRuntime.cs
@@ -23,6 +23,7 @@ internal class DispatchOperationRuntime
         private readonly IDispatchMessageFormatter _formatter;
         private IParameterInspector[] _inspectors;
         private readonly IOperationInvoker _invoker;
+        private readonly bool _isTerminating;
         private readonly bool _isSessionOpenNotificationEnabled;
         private readonly string _name;
         private readonly ImmutableDispatchRuntime _parent;
@@ -55,7 +56,7 @@ internal DispatchOperationRuntime(DispatchOperation operation, ImmutableDispatch
             _serializeReply = operation.SerializeReply;
             _formatter = operation.Formatter;
             _invoker = operation.Invoker;
-
+            _isTerminating = operation.IsTerminating;
             _isSessionOpenNotificationEnabled = operation.IsSessionOpenNotificationEnabled;
             _action = operation.Action;
             _name = operation.Name;
@@ -98,6 +99,11 @@ internal bool IsOneWay
             get { return _isOneWay; }
         }
 
+        internal bool IsTerminating
+        {
+            get { return _isTerminating; }
+        }
+
         internal string Name
         {
             get { return _name; }
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/ImmutableDispatchRuntime.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/ImmutableDispatchRuntime.cs
@@ -26,6 +26,7 @@ internal class ImmutableDispatchRuntime
         private readonly bool _enableFaults;
         private InstanceBehavior _instance;
         private readonly bool _manualAddressing;
+        private readonly TerminatingOperationBehavior _terminate;
         private readonly ThreadBehavior _thread;
         private readonly bool _validateMustUnderstand;
         private readonly bool _sendAsynchronously;
@@ -54,6 +55,7 @@ internal ImmutableDispatchRuntime(DispatchRuntime dispatch)
             _enableFaults = dispatch.EnableFaults;
             _instance = new InstanceBehavior(dispatch, this);
             _manualAddressing = dispatch.ManualAddressing;
+            _terminate = TerminatingOperationBehavior.CreateIfNecessary(dispatch);
             _thread = new ThreadBehavior(dispatch);
             _sendAsynchronously = dispatch.ChannelDispatcher.SendAsynchronously;
             _correlationCount = dispatch.MaxParameterInspectors;
@@ -826,6 +828,21 @@ private void ProcessMessageCleanup(ref MessageRpc rpc)
                     }
                 }
 
+                if (_terminate != null)
+                {
+                    try
+                    {
+                        _terminate.AfterReply(ref rpc);
+                    }
+                    catch (Exception e)
+                    {
+                        if (Fx.IsFatal(e))
+                        {
+                            throw;
+                        }
+                        _error.HandleError(e);
+                    }
+                }
 
                 if (rpc.SuccessfullyIncrementedActivity)
                 {
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/ProxyOperationRuntime.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/ProxyOperationRuntime.cs
@@ -17,6 +17,7 @@ internal class ProxyOperationRuntime
         private readonly IClientMessageFormatter _formatter;
         private readonly bool _isInitiating;
         private readonly bool _isOneWay;
+        private readonly bool _isTerminating;
         private readonly bool _isSessionOpenNotificationEnabled;
         private readonly string _name;
         private readonly IParameterInspector[] _parameterInspectors;
@@ -46,6 +47,7 @@ internal ProxyOperationRuntime(ClientOperation operation, ImmutableClientRuntime
             _formatter = operation.Formatter;
             _isInitiating = operation.IsInitiating;
             _isOneWay = operation.IsOneWay;
+            _isTerminating = operation.IsTerminating;
             _isSessionOpenNotificationEnabled = operation.IsSessionOpenNotificationEnabled;
             _name = operation.Name;
             _parameterInspectors = EmptyArray<IParameterInspector>.ToArray(operation.ParameterInspectors);
@@ -106,6 +108,11 @@ internal bool IsOneWay
             get { return _isOneWay; }
         }
 
+        internal bool IsTerminating
+        {
+            get { return _isTerminating; }
+        }
+
         internal bool IsSessionOpenNotificationEnabled
         {
             get { return _isSessionOpenNotificationEnabled; }
diff --git a/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/TerminatingOperationBehavior.cs b/src/System.Private.ServiceModel/src/System/ServiceModel/Dispatcher/TerminatingOperationBehavior.cs
diff --git a/src/System.Private.ServiceModel/tests/Scenarios/Client/ClientBase/SessionTests.cs b/src/System.Private.ServiceModel/tests/Scenarios/Client/ClientBase/SessionTests.cs
diff --git a/src/System.ServiceModel.Primitives/ref/System.ServiceModel.Primitives.cs b/src/System.ServiceModel.Primitives/ref/System.ServiceModel.Primitives.cs
diff --git a/src/System.ServiceModel.Primitives/tests/Description/OperationContractAttributeTest.cs b/src/System.ServiceModel.Primitives/tests/Description/OperationContractAttributeTest.cs

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,7 @@ internal sealed class ServiceChannel : CommunicationObject, IChannel, IClientCha`
`47`	`47`	`private readonly bool _openBinder = false;`
`48`	`48`	`private TimeSpan _operationTimeout;`
`49`	`49`	`private object _proxy;`
	`50`	`+ private string _terminatingOperationName;`
`50`	`51`	`private bool _hasChannelStartedAutoClosing;`
`51`	`52`	`private bool _hasCleanedUpChannelCollections;`
`52`	`53`	`private EventTraceActivity _eventActivity;`
`@@ -566,6 +567,11 @@ private void PrepareCall(ProxyOperationRuntime operation, bool oneway, ref Proxy`
`566`	`567`	`throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new InvalidOperationException(SR.Format(SR.SFxNonInitiatingOperation1, operation.Name)));`
`567`	`568`	`}`
`568`	`569`
	`570`	`+ if (_terminatingOperationName != null)`
	`571`	`+ {`
	`572`	`+ throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new InvalidOperationException(SR.Format(SR.SFxTerminatingOperationAlreadyCalled1, _terminatingOperationName)));`
	`573`	`+ }`
	`574`	`+`
`569`	`575`	`if (_hasChannelStartedAutoClosing)`
`570`	`576`	`{`
`571`	`577`	`throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new ProtocolException(SR.SFxClientOutputSessionAutoClosed));`
`@@ -934,6 +940,7 @@ private void HandleReply(ProxyOperationRuntime operation, ref ProxyRpc rpc)`
`934`	`940`	`operation.Name,`
`935`	`941`	`rpc.Reply.Headers.Action,`
`936`	`942`	`operation.ReplyAction));`
	`943`	`+ TerminateIfNecessary(ref rpc);`
`937`	`944`	`throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(error);`
`938`	`945`	`}`
`939`	`946`	`}`
`@@ -947,6 +954,7 @@ private void HandleReply(ProxyOperationRuntime operation, ref ProxyRpc rpc)`
`947`	`954`	`}`
`948`	`955`	`ThrowIfFaultUnderstood(rpc.Reply, fault, action, rpc.Reply.Version, rpc.Channel.GetProperty<FaultConverter>());`
`949`	`956`	`FaultException fe = rpc.Operation.FaultFormatter.Deserialize(fault, action);`
	`957`	`+ TerminateIfNecessary(ref rpc);`
`950`	`958`	`throw DiagnosticUtility.ExceptionUtility.ThrowHelperWarning(fe);`
`951`	`959`	`}`
`952`	`960`
`@@ -982,6 +990,7 @@ private void HandleReply(ProxyOperationRuntime operation, ref ProxyRpc rpc)`
`982`	`990`	`}`
`983`	`991`	`}`
`984`	`992`	`}`
	`993`	`+ TerminateIfNecessary(ref rpc);`
`985`	`994`
`986`	`995`	`if (WcfEventSource.Instance.ServiceChannelCallStopIsEnabled())`
`987`	`996`	`{`
`@@ -996,6 +1005,15 @@ private void HandleReply(ProxyOperationRuntime operation, ref ProxyRpc rpc)`
`996`	`1005`	`}`
`997`	`1006`	`}`
`998`	`1007`
	`1008`	`+ private void TerminateIfNecessary(ref ProxyRpc rpc)`
	`1009`	`+ {`
	`1010`	`+ if (rpc.Operation.IsTerminating)`
	`1011`	`+ {`
	`1012`	`+ _terminatingOperationName = rpc.Operation.Name;`
	`1013`	`+ TerminatingOperationBehavior.AfterReply(ref rpc);`
	`1014`	`+ }`
	`1015`	`+ }`
	`1016`	`+`
`999`	`1017`	`private void ThrowIfFaultUnderstood(Message reply, MessageFault fault, string action, MessageVersion version, FaultConverter faultConverter)`
`1000`	`1018`	`{`
`1001`	`1019`	`Exception exception;`
Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,7 @@ internal void EnsureInvariants()`
`228`	`228`	`operationDescription.EnsureInvariants();`
`229`	`229`	`if (operationDescription.IsInitiating)`
`230`	`230`	`thereIsAtLeastOneInitiatingOperation = true;`
`231`		`- if ((!operationDescription.IsInitiating)`
	`231`	`+ if ((!operationDescription.IsInitiating \|\| operationDescription.IsTerminating)`
`232`	`232`	`&& (this.SessionMode != SessionMode.Required))`
`233`	`233`	`{`
`234`	`234`	`throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new InvalidOperationException(`
Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,7 @@ private static void BuildProxyOperation(OperationDescription operation, ClientRu`
`134`	`134`	`child.EndMethod = operation.EndMethod;`
`135`	`135`	`child.IsOneWay = operation.IsOneWay;`
`136`	`136`	`child.IsInitiating = operation.IsInitiating;`
	`137`	`+ child.IsTerminating = operation.IsTerminating;`
`137`	`138`	`child.IsSessionOpenNotificationEnabled = operation.IsSessionOpenNotificationEnabled;`
`138`	`139`	`for (int i = 0; i < operation.Faults.Count; i++)`
`139`	`140`	`{`
`@@ -160,6 +161,7 @@ private static void BuildDispatchOperation(OperationDescription operation, Dispa`
`160`	`161`
`161`	`162`	`child.HasNoDisposableParameters = operation.HasNoDisposableParameters;`
`162`	`163`
	`164`	`+ child.IsTerminating = operation.IsTerminating;`
`163`	`165`	`child.IsSessionOpenNotificationEnabled = operation.IsSessionOpenNotificationEnabled;`
`164`	`166`	`for (int i = 0; i < operation.Faults.Count; i++)`
`165`	`167`	`{`