Add group to get SDL validation params. #3988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@sunandabalu I'm not all that good with yaml, could you check this for me and see if I added the group correctly and that I used the proper variables. Thanks. |
sunandabalu
requested changes
Oct 22, 2019
azure-pipelines-arcade.yml
Outdated
| - template: eng\common\templates\post-build\post-build.yml | ||
| parameters: | ||
| variables: | ||
| - group: SDL_Settings |
Member
There was a problem hiding this comment.
This variable group has values specific to Arcade, please do not use this. Create one of your own.
Member
There was a problem hiding this comment.
And variable group needs to be added here -
wcf/azure-pipelines-arcade.yml
Line 34 in 9c7d5d8
Member
Author
There was a problem hiding this comment.
Thanks for your assistance @sunandabalu
Added a Wcf group for the SDL validation params and amended the commit.
StephenBonikowsky
force-pushed
the
stebon/3.1.0/infraupdates
branch
from
9c7d5d8 to
73ae767
Compare
Member
|
LGTM |
sunandabalu
approved these changes
Oct 22, 2019
Member
Author
|
CI failure is understood, not related to these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DevDiv changed the bug area path.
@sunandabalu created a variable group to use.