added Microsoft.VisualBasic.dll to the package file list #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
approved these changes
Nov 19, 2019
Member
dagood
left a comment
dagood
left a comment
There was a problem hiding this comment.
Thanks. I think CI will fail though, because this adds a classification for a file that doesn't exist in the current master branch. This commit will need to be rebased onto #187 and pushed. (If you want to keep this change in a non-bot PR, you can also grab the commits from #187 and push them to this PR.)
Contributor
Author
|
Thanks Davis, I made the change directly in #187 and pushed it. Going to close this PR without merging. |
Member
|
Does Microsoft.VisualBasic.Forms.dll also need to be added ? /cc @rladuca |
Member
|
Yeah, but https://github.com/dotnet/winforms/pull/2396/files#diff-6fb3eac8ca40fdf61a2997bd480303fbR9 needs to flow here first so the file actually exists. Currently blocked in WPF: dotnet/wpf#2118. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.