Use the live crossgen2 corresponding to the runtime we're building against. #4815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mmitche
approved these changes
Dec 19, 2024
ViktorHofer
reviewed
Dec 20, 2024
|
@mmitche @dotnet/dotnet-winforms can I get someone to merge this in? I don't have merge permissions here. |
ViktorHofer
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen incompatibilities between older crossgen2 versions and newer runtimes. To ensure consistency in how we construct the product, this PR updates the reference to crossgen2 to use the live crossgen2 from dotnet/runtime.
Opening as draft as getting this working in the VMR will require work across multiple repos and I want to validate the VMR experience before merging any of the changes.