[Release/10.0] Remove unnecessary architecture-specific conditionals from MsiPackageElements #5336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merriemcgaw
changed the title
merriemcgaw
requested review from
NikolaMilosavljevic,
Shyam-Gupta and
joeloff
NikolaMilosavljevic
approved these changes
Oct 13, 2025
Member
Author
|
Approved over email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Impact
Runtime prerequisite MSIs were only being included in the x86 package due to unnecessary architecture-specific conditions that were in the MSIPackageElements section of the bundle.wxs. This removes the unnecessary conditionals and allows for the prerequisite MSIs to be included.
Regression
Testing
Manual SxS testing and bundle package inspection across all architectures. CTI install/uninstall. Build log inspection.
Risk
Low, the only removes conditionals that were blocking MSIs from being included in the final bundle builds.