[Release/10.0] Fix WindowsDesktop installer localization #5344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes three critical issues preventing localized UI display: 1. Incorrect WixLocalization Culture/Language attributes - All 13 non-English .wxl files had Culture="en-us" Language="1033" - Fixed to correct locale values (de-DE/1031, fr-FR/1036, ja-JP/1041, etc.) 2. Wrong Payload naming convention in bundle.wxs - Changed Name from $(lcid)\bundle.wxl to $(lcid)\thm.wxl - WixStandardBootstrapperApplication requires thm.wxl naming 3. Missing WixLocalization ItemGroup in bundle.wixproj - Added to ensure localization files are included in build output The installer now correctly displays translated UI in all 13 supported languages (zh-TW, cs-CZ, de-DE, fr-FR, it-IT, ja-JP, ko-KR, pl-PL, pt-BR, ru-RU, tr-TR, zh-CN, es-ES) with automatic detection based on Windows display language.
The WelcomeDescription string was left in English in these locales: - de-DE (1031) - German - fr-FR (1036) - French - ja-JP (1041) - Japanese - pl-PL (1045) - Polish - pt-BR (1046) - Portuguese - es-ES (3082) - Spanish Now properly translated in all languages.
The three hyperlinks on the Install page (Privacy Statement, Licensing Information, and Telemetry) were hardcoded in English in bundle.thm instead of using localization tokens. Changed: - Privacy Statement -> #(loc.PrivacyStatementLink) - Licensing Information for .NET -> #(loc.EulaLink) - Telemetry collection and opt-out -> #(loc.TelemetryLink) All localized .wxl files already contain translations for these strings, so this change enables proper display in all 13 supported languages.
merriemcgaw
requested review from
NikolaMilosavljevic,
PranavSenthilnathan,
Shyam-Gupta and
joeloff
Shyam-Gupta
approved these changes
Oct 15, 2025
mmitche
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Windows Desktop Runtime installer bundle localization
This PR fixes critical issues preventing the Windows Desktop Runtime installer from displaying localized UI in non-English languages.
Issues Fixed
Incorrect WixLocalization Culture/Language attributes - All 13 non-English
.wxlfiles hadCulture="en-us" Language="1033"instead of their correct locale values (e.g.,de-DE/1031,es-ES/3082)Wrong Payload naming convention -
bundle.wxsreferenced$(lcid)\bundle.wxlbut WixStandardBootstrapperApplication requires$(lcid)\thm.wxlMissing WixLocalization ItemGroup -
bundle.wixprojdidn't include the localization files in the build outputHardcoded English hyperlinks - Privacy Statement, Licensing Information, and Telemetry links were hardcoded in English in
bundle.thminstead of using localization tokensMissing WelcomeDescription translations - Six locales (de-DE, fr-FR, ja-JP, pl-PL, pt-BR, es-ES) had English text instead of translations
Result
The installer now correctly displays translated UI in all 13 supported languages (zh-CN, zh-TW, cs-CZ, de-DE, es-ES, fr-FR, it-IT, ja-JP, ko-KR, pl-PL, pt-BR, ru-RU, tr-TR) with automatic detection based on Windows display language.
Tested with Spanish (es-ES) locale and spot-checked others- all UI elements including welcome text and hyperlinks now display correctly in Spanish.
Risk
Minimal. Only touching loc related files.