Implement the ITypeDiscoveryService service#10247
Merged
Tanya-Solyanik merged 5 commits intodotnet:mainfrom Nov 20, 2023
Merged
Implement the ITypeDiscoveryService service#10247Tanya-Solyanik merged 5 commits intodotnet:mainfrom
Tanya-Solyanik merged 5 commits intodotnet:mainfrom
Conversation
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/TypeDiscoveryService.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/TypeDiscoveryService.cs
Outdated
Show resolved
Hide resolved
Contributor
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, I added one minor comment.
....Windows.Forms/tests/IntegrationTests/DesignSurface/DesignSurfaceExt/TypeDiscoveryService.cs
Outdated
Show resolved
Hide resolved
....Windows.Forms/tests/IntegrationTests/DesignSurface/DesignSurfaceExt/TypeDiscoveryService.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9870
Proposed changes
ServiceContainerof IDesignerHostRoot cause of this issue:
PopulateColumnTypesCombofunction, the code attempts to obtain anITypeDiscoveryServiceinstance through the GetService method ofIDesignerHostin order to discover all subtypes ofDataGridViewColumn.However, because
ITypeDiscoveryServiceis not added in the default service containerServiceContainerofIDesignerHost,GetServicereturns null.winforms/src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DataGridViewAddColumnDialog.cs
Lines 657 to 673 in 1d604b5
Customer Impact
Risk
Screenshots
Before
The column type is empty

After
The DataGridView column can be added normally from the Add column page
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow