Fix a bug introduced in the DesignerActionPanel refactoring #10123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
halgab
force-pushed
the
fix-DesignerActionPanel
branch
2 times, most recently
from
c5daf38 to
2f11603
Compare
halgab
commented
Oct 16, 2023
| public new sealed class Info(DesignerActionList list, DesignerActionTextItem item) : StandardLineInfo(list) | ||
| public static StandardLineInfo CreateLineInfo(DesignerActionList list, DesignerActionTextItem item) => new HeaderTextLineInfo(list, item); | ||
|
|
||
| private sealed class HeaderTextLineInfo(DesignerActionList list, DesignerActionTextItem item) : TextLineInfo(list, item) |
Contributor
Author
There was a problem hiding this comment.
That's the crux of the fix. HeaderInfo (formerly HeaderLine.Info) needs to be of type TextLineInfo (formerly TextLine.Info) because otherwise HeaderInfo.UpdateActionItem crashes as it cannot cast the LineInfo object
halgab
force-pushed
the
fix-DesignerActionPanel
branch
from
2f11603 to
415b471
Compare
LeafShi1
approved these changes
Oct 16, 2023
Tanya-Solyanik
approved these changes
Oct 16, 2023
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Thank you for jumping on it!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug introduced in #10035
Fixes #10095
Fixes #10097
I refactored a bit the code to make the mistake more obvious.
Proposed changes
Test methodology
Microsoft Reviewers: Open in CodeFlow