Run dotnet format on src and tests & fix other formatting issues #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
If CI passes, looks good to me. :) |
AdamYoblick
approved these changes
May 23, 2019
added 9 commits
May 23, 2019 13:38
zsd4yr
force-pushed
the
dev/zadanz/dotnet-format
branch
from
e5515b8 to
4947fb7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
===================================================
- Coverage 32.21598% 31.24619% -0.96979%
===================================================
Files 1097 1097
Lines 297756 318330 +20574
Branches 38388 38388
===================================================
+ Hits 95925 99466 +3541
- Misses 197651 214679 +17028
- Partials 4180 4185 +5
|
RussKie
approved these changes
May 23, 2019
hughbe
approved these changes
May 24, 2019
Contributor
hughbe
left a comment
hughbe
left a comment
There was a problem hiding this comment.
Puts you back in the lead for number of lines changed!!
Contributor
Author
wait until I'm done ;) got some more coming! |
Contributor
Author
|
I figure its best to do this in one wave to prevent folks form having to merge / rebase too many times |
added 9 commits
May 24, 2019 12:01
…d with coalescing operator
…d with propogation and elvis operator
added 5 commits
May 24, 2019 12:43
…d with coalescence
zsd4yr
changed the title
This was referenced Aug 18, 2019
Closed
RussKie
pushed a commit
to JeremyKuhne/winforms
that referenced
this pull request
Aug 20, 2019
Fixes dotnet#1311 Fixes dotnet#1520 Fixes dotnet#1607 Fixes dotnet#1644 The bug was introduced as part of refactoring in dotnet#1034 - ordering got flipped with switching `as` to `is`. The confusion was likely caused by the fact that the property setter called its own getter. Update the code to be more explicit in terminology to hopefully avoid this from happening again.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #937