fix: Reduce preview font size #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsd4yr
reviewed
Jun 18, 2019
src/System.Windows.Forms.Design.Editors/src/System/Drawing/Design/FontNameEditor.cs
Outdated
Show resolved
Hide resolved
zsd4yr
reviewed
Jun 18, 2019
src/System.Windows.Forms.Design.Editors/src/System/Drawing/Design/FontNameEditor.cs
Outdated
Show resolved
Hide resolved
RussKie
force-pushed
the
fix_1106_reduce_FontNameEditor_preview_font_size
branch
from
4a19de6 to
d45ad87
Compare
* Reduce the preview font size to provide a better visual parity with NET Fx since the change of the default font in Core. * Prefer to align the preview to the bottom, if possible * Remove a vertical line to the right of the preview box as it serves no purpose Closes dotnet#1106
RussKie
force-pushed
the
fix_1106_reduce_FontNameEditor_preview_font_size
branch
from
d45ad87 to
dded46b
Compare
zsd4yr
approved these changes
Jun 20, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the preview font size to provide a better visual parity with NET Fx since the change of the default font in Core.
Prefer to align the preview to the bottom, if possible
Remove a vertical line to the right of the preview box as it serves no purpose
Closes #1106