Skip to content

Implementing UIA provider for ErrorProvider #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2019
Merged

Implementing UIA provider for ErrorProvider #2381

merged 1 commit into from
Dec 6, 2019

Conversation

@vladimir-krestov
Copy link
Contributor

@vladimir-krestov vladimir-krestov commented Nov 18, 2019 •
edited by ghost
Loading

Fixes #2016

Proposed changes

  • Implement AccessibleObject for ErrorProvider.ErrorWindow
  • Implement AccessibleObject for ErrorProvider.ControlItem

Customer Impact

  • Narrator announces error description if a user uses CapsLock+keyboard arrow combination to navigation

Regression?

  • No

Risk

  • Minimal, it is a new feature

Screenshots

Before

  • ErrorProvider AccessibleObject is not implemented
    image

After

  • Implemented accessibility tree and correct announcing by Narrator
    image
    image

Test methodology

  • CTI
  • Manual UI testing

Accessibility testing

  • Using Inspect and Narrator tools

Test environment(s)

  • SDK Version: 5.0.100-alpha1-015730
  • Microsoft Windows [Version 10.0.18363.418]
Microsoft Reviewers: Open in CodeFlow

@vladimir-krestov vladimir-krestov requested a review from a team as a code owner November 18, 2019 13:58
@vladimir-krestov vladimir-krestov changed the title Implementing UIA provider for ErrorProvider WIP: Implementing UIA provider for ErrorProvider Nov 18, 2019
@vladimir-krestov vladimir-krestov self-assigned this Nov 18, 2019
@vladimir-krestov vladimir-krestov mentioned this pull request Nov 18, 2019
Closed
@codecov
Copy link

codecov bot commented Nov 18, 2019 •
edited
Loading

Codecov Report

Merging #2381 into master will decrease coverage by 0.01836%.
The diff coverage is 5.14018%.

@@                 Coverage Diff                 @@
##              master       #2381         +/-   ##
===================================================
- Coverage   29.44885%   29.43049%   -0.01837%     
===================================================
  Files           1005        1007          +2     
  Lines         259623      259819        +196     
  Branches       36853       36873         +20     
===================================================
+ Hits           76456       76466         +10     
- Misses        178232      178420        +188     
+ Partials        4935        4933          -2
Flag Coverage Δ
#Debug 29.43049% <5.14018%> (-0.01837%) ⬇️
#production 29.43049% <5.14018%> (-0.01837%) ⬇️
#test 100% <ø> (?)

@vladimir-krestov vladimir-krestov added the waiting-review This item is waiting on review by one or more members of team label Nov 19, 2019
RussKie
RussKie reviewed Nov 20, 2019
View reviewed changes
@RussKie RussKie added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Nov 20, 2019
@ghost ghost added the no-recent-activity label Nov 27, 2019
@ghost
Copy link

ghost commented Nov 27, 2019

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost removed waiting-author-feedback The team requires more information from the author no-recent-activity labels Nov 27, 2019
@vladimir-krestov
Copy link
Contributor Author

vladimir-krestov commented Nov 27, 2019

Haven't tested yet ❌

@vladimir-krestov vladimir-krestov force-pushed the dev/v-vlkres/2016_ErrorProviderUIA branch from e321a41 to 5b96fde Compare November 27, 2019 12:56
RussKie
RussKie reviewed Nov 27, 2019
View reviewed changes
Copy link
Contributor

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vladimir-krestov vladimir-krestov mentioned this pull request Nov 29, 2019
Closed
@vladimir-krestov vladimir-krestov added waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) and removed waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) labels Dec 2, 2019
@vladimir-krestov
Copy link
Contributor Author

vladimir-krestov commented Dec 2, 2019

Testers approved these changes ✔️

@vladimir-krestov vladimir-krestov force-pushed the dev/v-vlkres/2016_ErrorProviderUIA branch from 5b96fde to 09ccc30 Compare December 2, 2019 15:29
@vladimir-krestov vladimir-krestov changed the title WIP: Implementing UIA provider for ErrorProvider Implementing UIA provider for ErrorProvider Dec 2, 2019
@vladimir-krestov vladimir-krestov force-pushed the dev/v-vlkres/2016_ErrorProviderUIA branch from 09ccc30 to 510cc7a Compare December 2, 2019 15:45
@RussKie
Copy link
Contributor

RussKie commented Dec 3, 2019

Please add tests

@vladimir-krestov vladimir-krestov changed the title Implementing UIA provider for ErrorProvider WIP: Implementing UIA provider for ErrorProvider Dec 3, 2019
@vladimir-krestov
Implemented UIA provider for ErrorProvider
2368c92 
PR dotnet#2381
Fixes dotnet#2016

Added ErrorWindowAccessibleObject as FragmentRoot and its child - ControlItemAccessibleObject
Both classes support UIA provider

Fixed resources

Added unit tests
@vladimir-krestov vladimir-krestov force-pushed the dev/v-vlkres/2016_ErrorProviderUIA branch from 78c25c8 to 2368c92 Compare December 4, 2019 11:13
@vladimir-krestov
Copy link
Contributor Author

vladimir-krestov commented Dec 4, 2019

@RussKie the unit tests were added. Please check. PR is ready to merge.

@vladimir-krestov vladimir-krestov changed the title WIP: Implementing UIA provider for ErrorProvider Implementing UIA provider for ErrorProvider Dec 4, 2019
@RussKie RussKie merged commit 33a14f8 into dotnet:master Dec 6, 2019
@ghost ghost added this to the 5.0 milestone Dec 6, 2019
@vladimir-krestov vladimir-krestov deleted the dev/v-vlkres/2016_ErrorProviderUIA branch November 4, 2020 07:37
@vladimir-krestov vladimir-krestov mentioned this pull request Aug 31, 2021
Closed
70 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@RussKie RussKie RussKie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vladimir-krestov vladimir-krestov

Labels

None yet

Projects

None yet

Milestone

5.0 Previews 1-4

Development

Successfully merging this pull request may close these issues.

Ensure ErrorProvider supports all accessibility requirements.

2 participants

@vladimir-krestov @RussKie