Fix getting stock objects (#3774) #3776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stock objects have a different define in metafile records. Correct values for API usage. Add rectangle validation to the EMF validator and add regression tests for button and the Interop definitions.
Member
|
Approved for RC1. |
Codecov Report
@@ Coverage Diff @@
## release/5.0-rc1 #3776 +/- ##
==========================================================
- Coverage 67.39766% 36.18806% -31.20961%
==========================================================
Files 1393 916 -477
Lines 504657 250403 -254254
Branches 40895 36662 -4233
==========================================================
- Hits 340127 90616 -249511
+ Misses 158702 154671 -4031
+ Partials 5828 5116 -712
Flags with carried forward coverage won't be shown. Click here to find out more. |
RussKie
approved these changes
Aug 26, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stock objects have a different define in metafile records. Correct values for API usage.
Add rectangle validation to the EMF validator and add regression tests for button and the Interop definitions.
Ported from #3774 / 6f4b818
Customer Impact
Regression?
Risk
Microsoft Reviewers: Open in CodeFlow