Skip to content

Add support UIA provider for CheckedListBox control #5276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2021
Merged

Add support UIA provider for CheckedListBox control #5276

merged 1 commit into from
Sep 1, 2021

Conversation

@lisoenot
Copy link
Contributor

@lisoenot lisoenot commented Jul 19, 2021 •
edited
Loading

Related Issue: #3421

Proposed changes

  • Switched on the SupportsUiaProviders property of CheckedListBox class.
  • Updated uia properties.
  • Added unit tests.

Customer Impact

  • Improving development experience for CheckedListBox control accessibility.

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

CheckedListBox parent under inspect

clb fw parent

CheckedListBox item under inspect

clb fw item checked

CheckedListBox control under narrator

nb cld before

After

CheckedListBox parent under inspect

new 22

CheckedListBox item under inspect

new 11

Test methodology

  • Manually.
  • Unit tests.
  • Automation tests.

Accessibility testing

  • Inspect
  • Narrator
  • Accessibility Insights

Test environment(s)

  • .Net SDK version: 6.0.100-rc.1.21377.33
Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned lisoenot Jul 19, 2021
@lisoenot lisoenot force-pushed the Implementing-support-UIA-provider-for-CheckedListBox branch 5 times, most recently from 114d154 to fbe0d91 Compare July 26, 2021 13:29
@vladimir-krestov vladimir-krestov self-requested a review July 27, 2021 05:15
@lisoenot lisoenot force-pushed the Implementing-support-UIA-provider-for-CheckedListBox branch 5 times, most recently from 08182fa to 2baf170 Compare July 29, 2021 07:59
vladimir-krestov
vladimir-krestov reviewed Jul 30, 2021
View reviewed changes
Copy link
Contributor

@vladimir-krestov vladimir-krestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be reworked

@vladimir-krestov vladimir-krestov added the 🚧 work in progress Work that is current in progress label Jul 30, 2021
@lisoenot lisoenot force-pushed the Implementing-support-UIA-provider-for-CheckedListBox branch from 2baf170 to 6fe360e Compare July 30, 2021 12:58
@vladimir-krestov vladimir-krestov mentioned this pull request Aug 3, 2021
Closed
70 tasks
SergeySmirnov-Akvelon
SergeySmirnov-Akvelon reviewed Aug 3, 2021
View reviewed changes
@lisoenot lisoenot force-pushed the Implementing-support-UIA-provider-for-CheckedListBox branch from 6fe360e to a48a60a Compare August 3, 2021 10:11
@lisoenot lisoenot marked this pull request as ready for review August 4, 2021 08:43
@lisoenot lisoenot requested a review from a team as a code owner August 4, 2021 08:43
@lisoenot lisoenot added waiting-review This item is waiting on review by one or more members of team and removed 🚧 work in progress Work that is current in progress labels Aug 12, 2021
@lisoenot lisoenot force-pushed the Implementing-support-UIA-provider-for-CheckedListBox branch from a48a60a to 2e978af Compare August 12, 2021 11:20
@lisoenot lisoenot added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Aug 12, 2021
@lisoenot
Copy link
Contributor Author

lisoenot commented Aug 16, 2021 •
edited
Loading

Fix a test issues are in progress

@lisoenot lisoenot added 🚧 work in progress Work that is current in progress and removed waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) waiting-review This item is waiting on review by one or more members of team labels Aug 16, 2021
@lisoenot lisoenot force-pushed the Implementing-support-UIA-provider-for-CheckedListBox branch from 2e978af to 54d20a7 Compare August 16, 2021 14:57
@lisoenot lisoenot force-pushed the Implementing-support-UIA-provider-for-CheckedListBox branch 2 times, most recently from 9ba5fc8 to f58bf3d Compare August 24, 2021 08:41
@lisoenot
Copy link
Contributor Author

lisoenot commented Aug 24, 2021 •
edited
Loading

I have 2 from 3 fixed test-issue. One problem isn't resolved. So, PR is still WIP

@lisoenot lisoenot added 🚧 work in progress Work that is current in progress and removed waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) labels Aug 24, 2021
Implemented uia provider support for CheckedListBox
9cfcd14 
Inherited CheckedListBoxAccessibleObject from ListBoxAccessibleObject;
inherited CheckedListBoxItemAccessibleObject from ListBoxItemAccessibleObject;
updated apearing elements of MultipleContols form and added a clb with vscroll-bar;
changed announcing after check/uncheck item action:
use "checked/unchecked" instead of "{Name} {type} checked/unchecked".
@lisoenot lisoenot force-pushed the Implementing-support-UIA-provider-for-CheckedListBox branch from f58bf3d to 9cfcd14 Compare August 24, 2021 13:20
@lisoenot lisoenot added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Aug 24, 2021
@lisoenot
Copy link
Contributor Author

lisoenot commented Aug 25, 2021

Testers approved the fix: there are no regression issues here.

@lisoenot lisoenot added waiting-review This item is waiting on review by one or more members of team and removed waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) 🚧 work in progress Work that is current in progress labels Aug 25, 2021
@lisoenot lisoenot changed the title Implementing support UIA provider for CheckedListBox control Add support UIA provider for CheckedListBox control Aug 25, 2021
dreddy-work
dreddy-work reviewed Aug 25, 2021
View reviewed changes
Copy link
Member

@dreddy-work dreddy-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @vladimir-krestov and @Tanya-Solyanik to approve.

Tanya-Solyanik
Tanya-Solyanik approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Tanya-Solyanik
Copy link
Contributor

Tanya-Solyanik commented Sep 1, 2021

@DmitryGorokhov - are you ready to merge?

@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label Sep 1, 2021
@RussKie RussKie merged commit 4ce6b02 into dotnet:main Sep 1, 2021
@ghost ghost added this to the 7.0 alpha1 milestone Sep 1, 2021
@RussKie
Copy link
Contributor

RussKie commented Sep 1, 2021

Port to RC2?

@lisoenot lisoenot deleted the Implementing-support-UIA-provider-for-CheckedListBox branch September 1, 2021 07:45
lisoenot added a commit to lisoenot/winforms that referenced this pull request Sep 1, 2021
@lisoenot
Add support UIA provider for CheckedListBox control (dotnet#5276)
0941769
@lisoenot lisoenot mentioned this pull request Sep 1, 2021
Merged
dreddy-work pushed a commit that referenced this pull request Sep 1, 2021
@lisoenot
Add support UIA provider for CheckedListBox control (#5276) (#5658)
e069f9b
@Philip-Wang01
Copy link
Contributor

Philip-Wang01 commented Sep 30, 2021

Verified this issue with .NET SDK 7.0.100-alpha.1.21479.33, Add support UIA provider for CheckedListBox control
image
image
image

@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers

@SergeySmirnov-Akvelon SergeySmirnov-Akvelon SergeySmirnov-Akvelon left review comments

@dreddy-work dreddy-work dreddy-work left review comments

@RussKie RussKie RussKie approved these changes

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@vladimir-krestov vladimir-krestov vladimir-krestov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lisoenot lisoenot

Labels

None yet

Projects

None yet

Milestone

7.0 Preview1

Development

Successfully merging this pull request may close these issues.

7 participants

@lisoenot @dreddy-work @Tanya-Solyanik @RussKie @Philip-Wang01 @SergeySmirnov-Akvelon @vladimir-krestov