Fix nested container controls scaling that have AutoscaleMode as Inherit #6130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreddy-work
added
the
waiting-for-testing
| // Traverse thorugh parent hierarchy untill we get a ContainerControl whose AutoScaleMode is not Inherit. | ||
| // AutoscaleFactor from this parent is used to scale the child controls within its hierarchy. | ||
| while (parentControl is not null | ||
| && (parentControl is not ContainerControl containerControl |
Contributor
There was a problem hiding this comment.
We have other places with similar code walking the parent chain, don't we? Do we always skip non-container controls?
Member
Author
There was a problem hiding this comment.
AutoscaleFactor is property on ContainerControl . So, we have to traverse parent chain until we get the right scale factor for its children. Also, ContainerControl gets OnFonChanged events to scale the children. Non-Container controls that receive OnFontChanged does not scale control but just set the Font.
src/System.Windows.Forms/src/System/Windows/Forms/ContainerControl.cs
Outdated
Show resolved
Hide resolved
RussKie
approved these changes
Nov 9, 2021
dreddy-work
removed
the
waiting-for-testing
Member
Author
|
CTI cleared testing. |
filipnavara
pushed a commit
to emclient/winforms
that referenced
this pull request
Nov 11, 2021
…rit (dotnet#6130) * Fix nested container controls scaling that have AutoscaleMode as Inherit. Fixes dotnet#5957 and dotnet#6152.
dreddy-work
added a commit
that referenced
this pull request
Nov 11, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nested
Container Controlsscaling that haveAutoscaleModeasInherit. In this change we are making sure to traverse hierarchy all the way up until we get a container parent whoseAutoScaleModeis not Inherit and use it sAutoScaleFactorto scale children.Fixes #5957.
fixes #6152
Microsoft Reviewers: Open in CodeFlow