-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adding UIA support for toolStripContainer #6568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding UIA support for toolStripContainer #6568
Conversation
...dows.Forms/src/System/Windows/Forms/ToolStripContainer.ToolStripContainerAccessibleObject.cs
Show resolved
Hide resolved
e2fcb01 to
64ab5e5
Compare
64ab5e5 to
c50eb44
Compare
vladimir-krestov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if it works
...dows.Forms/src/System/Windows/Forms/ToolStripContainer.ToolStripContainerAccessibleObject.cs
Outdated
Show resolved
Hide resolved
...dows.Forms/src/System/Windows/Forms/ToolStripContainer.ToolStripContainerAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ToolStripContainer.cs
Outdated
Show resolved
Hide resolved
...ests/UnitTests/System/Windows/Forms/ToolStripContainer_ToolStripContainerAccessibleObject.cs
Show resolved
Hide resolved
031f779 to
49fc605
Compare
dreddy-work
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
...System.Windows.Forms/tests/IntegrationTests/WinformsControlsTest/WinformsControlsTest.csproj
Outdated
Show resolved
Hide resolved
...UnitTests/System/Windows/Forms/ToolStripContainer.ToolStripContainerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...UnitTests/System/Windows/Forms/ToolStripContainer.ToolStripContainerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...UnitTests/System/Windows/Forms/ToolStripContainer.ToolStripContainerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...UnitTests/System/Windows/Forms/ToolStripContainer.ToolStripContainerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...UnitTests/System/Windows/Forms/ToolStripContainer.ToolStripContainerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...dows.Forms/src/System/Windows/Forms/ToolStripContainer.ToolStripContainerAccessibleObject.cs
Outdated
Show resolved
Hide resolved
|
LGTM. Please take a look at some minor points. |
679c004 to
3ceacca
Compare
3ceacca to
5d3d98c
Compare
|
Hi @Cassie-Li01, it looks like you just commented on a closed PR. The team will most probably miss it. |
|
Verified with .NET SDK 7.0.100-preview.2.22152.5 build, this issue is fixed as same as above test result. |
|
Hi @John-Qiao, it looks like you just commented on a closed PR. The team will most probably miss it. |


Partially implements #3421
Proposed changes
Customer Impact
Before update:


After update:


Regression?
Risk
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow