Add MyType to VB WPF template

[nguerrera]

This is needed in support of getting VB code that uses My.* working out of the box.

Sync with @KathleenDollard on the correct content, but I think we want the following:

<PropertyGroup>
  <MyType>Console</MyType>
</PropertyGroup>

Eventually we will want something more like the MyType=Custom that you get in the classic VB WPF project, but Console is what works now.

[vatsan-madhavan]

See https://docs.microsoft.com/en-us/dotnet/visual-basic/developing-apps/customizing-extending-my/customizing-which-objects-are-available-in-my

[vatsan-madhavan]

I'd rather set MyType=Custom in the templates now and let the VB runtime catch-up.

[nguerrera]

Won't that cause a buIld failure? MyType=Custom also implies substantial change to the .vb in the template (compare to framework template). I don't see the harm in going in steps where more stuff works at each checkpoint.

[vatsan-madhavan]

MyType=Custom seems to build for me without any failures at this time. That said, it may not help with application ports immediately.

My concern with MyType=Console is twofold.

First is that that it might potentially expose functionality that doesn't exist (i.e., is not expected to exist) with MyType=Custom. Maybe my worry is baseless.. and Console is a strict subset of Custom used by WPF...

Secondly, its extra effort. If the right support for MyType=Custom is coming up shortly, then either we can use Custom in the templates now and wait for the support to light up, or we can just wait for the right support to light up and then change the templates.

[nguerrera]

Ok. I don't know enough about the implications here. + @cston

[nguerrera]

My understanding was that Console is what would work in 3.0 and the remaining parts of the runtime were for 3.1, but I may have misunderstood.

[nguerrera]

Since we're opting to do this in a template and not via magic targets, it won't be breaking if it causes something to be available that won't be in the final template because template changes won't be applied to existing projects.