Adding simsun-extg font to support more character #10517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
the
PR
dipeshmsft
reviewed
Feb 27, 2025
src/Microsoft.DotNet.Wpf/src/PresentationCore/Fonts/GlobalUserInterface.CompositeFont
Show resolved
Hide resolved
…user-composite-font
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10517 +/- ##
===================================================
- Coverage 11.39631% 11.22910% -0.16721%
===================================================
Files 3353 3353
Lines 668041 668041
Branches 74980 74980
===================================================
- Hits 76132 75015 -1117
- Misses 590563 591785 +1222
+ Partials 1346 1241 -105
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Kuldeep-MS
force-pushed
the
fix/global-user-composite-font
branch
from
4746997 to
d91a106
Compare
Contributor
|
SimSun-ExtG ranges look OK to me now, they are block aligned. |
src/Microsoft.DotNet.Wpf/src/PresentationCore/Fonts/GlobalUserInterface.CompositeFont
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationCore/Fonts/GlobalUserInterface.CompositeFont
Show resolved
Hide resolved
singhashish-wpf
approved these changes
Apr 29, 2025
Contributor
Author
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/wpf/actions/runs/15551475662 |
Contributor
Author
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/wpf/actions/runs/15551480615 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
Some Chinese characters are being displayed as boxes in WPF due to unavailability of the font.
Background Infromation
When text is rendered, each character's codepoint is searched in either the default font or the specified font. If the codepoint is not found, it falls back to composite fonts to locate the codepoint. These composite fonts are collections of different fonts that cover various codepoint ranges and are associated with different languages, enabling the rendering of characters.
Change Description
Adding Simsun-ExtG font and modifying the character range for the Simsun-ExtB font to GlobalUserInterface composite font. This will enable us to support more character from GB18030.
Customer Impact
all the characters will be displayed correctly, without this many of the Chinese characters will be displayed as boxes.
Regression
NA
Testing
In progress
Risk
Low
Microsoft Reviewers: Open in CodeFlow