Skip to content

Conversation

@harshit7962
Copy link
Member

@harshit7962 harshit7962 commented Nov 17, 2025

Ref: #11238

Microsoft Reviewers: Open in CodeFlow

dotnet-maestro bot and others added 6 commits November 7, 2025 02:08
Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.Helix.Sdk (Version 11.0.0-beta.25555.103 -> 11.0.0-beta.25556.111)
Microsoft.Dotnet.WinForms.ProjectTemplates, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Private.Winforms, System.CodeDom, System.Configuration.ConfigurationManager, System.Diagnostics.EventLog, System.DirectoryServices, System.Drawing.Common, System.Formats.Nrbf, System.IO.Packaging, System.Private.Windows.Core.TestUtilities, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Runtime.Serialization.Formatters, System.Security.Cryptography.Xml, System.Security.Permissions, System.Windows.Extensions (Version 10.0.0-rc.1.25555.103 -> 10.0.0-rc.3.25556.111)
Microsoft.DotNet.Wpf.DncEng (Version 10.0.0-rc.1.25552.1 -> 10.0.0-rc.1.25513.8)
Auto-resolved conflicts:
- eng/Version.Details.props
- eng/Version.Details.xml
Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.Helix.Sdk (Version 11.0.0-beta.25556.111 -> 11.0.0-beta.25560.108)
Microsoft.Dotnet.WinForms.ProjectTemplates, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Private.Winforms, System.CodeDom, System.Configuration.ConfigurationManager, System.Diagnostics.EventLog, System.DirectoryServices, System.Drawing.Common, System.Formats.Nrbf, System.IO.Packaging, System.Private.Windows.Core.TestUtilities, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Runtime.Serialization.Formatters, System.Security.Cryptography.Xml, System.Security.Permissions, System.Windows.Extensions (Version 10.0.0-rc.3.25556.111 -> 10.0.0-rc.3.25560.108)
@harshit7962 harshit7962 requested a review from a team as a code owner November 17, 2025 15:12
Copilot AI review requested due to automatic review settings November 17, 2025 15:12
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 17, 2025
Copilot finished reviewing on behalf of harshit7962 November 17, 2025 15:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates various dependencies from the dotnet/wpf repository, syncing with changes from the referenced upstream PR. The changes include dependency version bumps, tooling improvements, and configuration refinements.

  • Updated Arcade SDK and Helix SDK versions from 11.0.0-beta.25555.103 to 11.0.0-beta.25560.108
  • Updated .NET runtime dependencies from rc.1.25555.103 to rc.3.25560.108 and incremented PreReleaseVersionIteration from 1 to 3
  • Improved dotnet tool installation commands, MicroBuild configuration, and added CentOS support

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
global.json Updated Microsoft.DotNet.Arcade.Sdk and Microsoft.DotNet.Helix.Sdk to version 11.0.0-beta.25560.108
eng/common/native/install-dependencies.sh Added CentOS support to the package manager detection logic
eng/common/core-templates/steps/source-index-stage1-publish.yml Changed --add-source to --source for dotnet tool install commands
eng/common/core-templates/steps/publish-logs.yml Added quotes around parameter values for BinlogToolVersion and runtimeSourceFeedKey
eng/common/core-templates/steps/install-microbuild.yml Refactored MicroBuild output folder configuration with new parameter and updated comments
eng/common/core-templates/steps/install-microbuild-impl.yml Updated display names to remove Windows-specific references
eng/common/core-templates/post-build/post-build.yml Added .NET 8.0 SDK installation task and quoted runtimeSourceFeedKey parameter
eng/common/core-templates/job/publish-build-assets.yml Added .NET 8.0 SDK installation task, quoted runtimeSourceFeedKey parameter, and removed trailing whitespace
eng/Versions.props Incremented PreReleaseVersionIteration from 1 to 3
eng/Version.Details.xml Updated all product and toolset dependency versions to rc.3.25560.108 and updated SHA references
eng/Version.Details.props Updated all package versions to align with Version.Details.xml changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


localedef -i en_US -c -f UTF-8 -A /usr/share/locale/locale.alias en_US.UTF-8
elif [ "$ID" = "fedora" ] || [ "$ID" = "rhel" ] || [ "$ID" = "azurelinux" ]; then
elif [ "$ID" = "fedora" ] || [ "$ID" = "rhel" ] || [ "$ID" = "azurelinux" ] || [ "$ID" = "centos"]; then
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before closing bracket. The condition should be || [ "$ID" = "centos" ]; with a space before the closing bracket to follow proper bash syntax conventions.

Suggested change
elif [ "$ID" = "fedora" ] || [ "$ID" = "rhel" ] || [ "$ID" = "azurelinux" ] || [ "$ID" = "centos"]; then
elif [ "$ID" = "fedora" ] || [ "$ID" = "rhel" ] || [ "$ID" = "azurelinux" ] || [ "$ID" = "centos" ]; then

Copilot uses AI. Check for mistakes.
-SkipAssetsPublishing '${{ parameters.isAssetlessBuild }}'
-runtimeSourceFeed https://ci.dot.net/internal
-runtimeSourceFeedKey $(dotnetbuilds-internal-container-read-token-base64)
-runtimeSourceFeed https://ci.dot.net/internal
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected at the end of line 213. Consider removing it to maintain code cleanliness.

Copilot uses AI. Check for mistakes.
BARBuildId: ${{ parameters.BARBuildId }}
PromoteToChannelIds: ${{ parameters.PromoteToChannelIds }}
is1ESPipeline: ${{ parameters.is1ESPipeline }}

Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected at the end of line 192. Consider removing it to maintain code cleanliness.

Suggested change

Copilot uses AI. Check for mistakes.
-ArtifactsPublishingAdditionalParameters '${{ parameters.artifactsPublishingAdditionalParameters }}'
-SymbolPublishingAdditionalParameters '${{ parameters.symbolPublishingAdditionalParameters }}'
-SkipAssetsPublishing '${{ parameters.isAssetlessBuild }}'
-runtimeSourceFeed https://ci.dot.net/internal
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected at the end of line 336. Consider removing it to maintain code cleanliness.

Suggested change
-runtimeSourceFeed https://ci.dot.net/internal
-runtimeSourceFeed https://ci.dot.net/internal

Copilot uses AI. Check for mistakes.
@harshit7962
Copy link
Member Author

Closing as the original PR was force merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants