Skip to content

Remove dependency on CorError.h #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2019
Merged

Remove dependency on CorError.h #2300

merged 1 commit into from
Dec 11, 2019

Conversation

@SamBent
Copy link
Contributor

@SamBent SamBent commented Dec 10, 2019

Copy (from .NET 4.6.1 SDK) the one HR definition used by DirectWriteForwarder.

Fixes #2297

@SamBent SamBent added this to the 5.0 milestone Dec 10, 2019
@SamBent SamBent self-assigned this Dec 10, 2019
@ghost ghost requested review from rladuca and vatsan-madhavan December 10, 2019 18:27
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Dec 10, 2019
@SamBent SamBent merged commit 37c57fe into dotnet:master Dec 11, 2019
@SamBent SamBent deleted the SDK-includes branch December 11, 2019 17:34
@ghost ghost locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vatsan-madhavan vatsan-madhavan vatsan-madhavan approved these changes

+1 more reviewer

@rladuca rladuca rladuca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SamBent SamBent

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Remove dependency on .NET include file

3 participants

@SamBent @rladuca @vatsan-madhavan