-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove dependency on .NET SDK installs for IL Tools #2305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…et of matched tools (from .NET 4.7.2) so that we can always ensure round-tripping works and we do not need to require .NET Framework SDKs to be installed.
…r that needs it. This allows ILAsm to properly create the module reference without inference (which fails for private tools not run from Framework installations).
|
You have to undo @SamBent's documentation update. |
|
Instead of inventing new targets for ILAsm/ILDasm, you can reuse those supplied by As long as the commandline usage have remained largely compatible between .NET Framework and .NET Core versions of ILAsm/ILDasm, I suspect that this would be doable. |
I don't think those targets are fully featured. While you can override the IL(D)AsmDir properties to choose non-package based tools, it seems there is only a target to decompile resources and a target to compile an IL file. They also don't accept some switches that we use. Generally, they seem created for a specific purpose and not for general use unless I am missing something. |
😞 |
|
IL comparison seems fine, no major differences there between corresponding release DLLs. |
eng/WpfArcadeSdk/tools/InjectModuleInitializer/AddModuleConstructorTask.cs
Outdated
Show resolved
Hide resolved
…rence then module initializer. In cases where there is an existing mscorlib reference, we just replace it with the combined ref + initializer.
Fixes #2298
Use a set of matched, private IL tools in order to inject a module constructor into
PresentationCore. These are copied binaries from a .NET Framework 4.7.2 installation and SDK.Also fixing some issues with utilizing
ILAsmoutside of the installed Framework directory and some bugs that went unnoticed in our injection targets.Pending
PresentationCorefrom this change and current .NET 5.0PresentationCore.