Skip to content

Conversation

@vatsan-madhavan
Copy link
Member

@vatsan-madhavan vatsan-madhavan commented Feb 6, 2020

A few additional build orchestration fixups needed for an upcoming repo-refactoring.

ps: do not squash this PR - create a merge commit instead;

@ghost ghost requested a review from rladuca February 6, 2020 01:11
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Feb 6, 2020
@ghost ghost requested a review from SamBent February 6, 2020 01:11
@vatsan-madhavan vatsan-madhavan added this to the 5.0 milestone Feb 6, 2020
…poLocation=External. When RepoLocation=Internal, this package is not really needed.
…operties>` to native projects. This is needed to prevent these projects from building multiple times parallel.
@ghost
Copy link

ghost commented Feb 6, 2020

Hello @vatsan-madhavan!

Because this pull request has the auto_merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 30 minutes, a condition that will be fulfilled in about 18 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@vatsan-madhavan
Copy link
Member Author

@msftbot require 1 sign offs.

@ghost
Copy link

ghost commented Feb 6, 2020

Hello @vatsan-madhavan!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it has at least 1 approval

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@vatsan-madhavan
Copy link
Member Author

@msftbot create a merge commit

@ghost
Copy link

ghost commented Feb 6, 2020

Hello @vatsan-madhavan!

I think you told me that you would like to reset custom auto-merge settings, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@vatsan-madhavan
Copy link
Member Author

@msftbot override custom auto-merge settings - create a merge commit when merging

@ghost
Copy link

ghost commented Feb 6, 2020

Hello @vatsan-madhavan!

I think you told me that you would like to reset custom auto-merge settings, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@vatsan-madhavan
Copy link
Member Author

@msftbot do not squash

@vatsan-madhavan
Copy link
Member Author

@msftbot reset custom auto-merge settings

@ghost
Copy link

ghost commented Feb 6, 2020

Hello @vatsan-madhavan!

Because you've told me to reset the custom auto-merge settings, I'll use the configured settings for this repository when I'm merging this pull request.

@ghost ghost merged commit 37b6121 into dotnet:master Feb 6, 2020
@vatsan-madhavan vatsan-madhavan deleted the wpfbuild-fixups branch February 6, 2020 01:49
@ghost ghost locked as resolved and limited conversation to collaborators Apr 13, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto_merge bot-command PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant