SpellCheck incorrectly detects common abbreviations like "e.g." as misspellings #2871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
rladuca
approved these changes
Apr 10, 2020
lindexi
reviewed
Apr 11, 2020
...crosoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Documents/WinRTSpellerInterop.cs
Outdated
Show resolved
Hide resolved
lindexi
reviewed
Apr 11, 2020
...tNet.Wpf/src/PresentationFramework/System/Windows/Documents/WinRTSpellerInteropExtensions.cs
Outdated
Show resolved
Hide resolved
lindexi
reviewed
Apr 11, 2020
...tNet.Wpf/src/PresentationFramework/System/Windows/Documents/WinRTSpellerInteropExtensions.cs
Outdated
Show resolved
Hide resolved
lindexi
reviewed
Apr 11, 2020
...Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Documents/NLGSpellerInterop.cs
Outdated
Show resolved
Hide resolved
lindexi
reviewed
Apr 14, 2020
...tNet.Wpf/src/PresentationFramework/System/Windows/Documents/WinRTSpellerInteropExtensions.cs
Outdated
Show resolved
Hide resolved
lindexi
reviewed
Apr 14, 2020
...tNet.Wpf/src/PresentationFramework/System/Windows/Documents/WinRTSpellerInteropExtensions.cs
Outdated
Show resolved
Hide resolved
…t the end of words like "etc." This results in well-formed words like "etc.", "Mr.", "Mrs." being marked as spelling-errors. Further, it is impossible to "correct" these words in WPF. Becasue of the way word-breaking is performed by MS.Data.Text.WordsSegmenter under the hood, these punctuations are always dropped during word-breaking. The older spell-checker (NaturalLanguage6.dll) used on Win7 does not have this defect. MS.Data.Text.WordsSegmenter has declined to 'fix'/'modify this behavior, so we are adding a workaround in WPF. This change introduces a wrapper on top of the word-breaker and recalculates the tokens, taking into account dropped text that occurs immediately after a token that is likely to fail spell-checking.
…reaking with aid from a spell-checker
…d organizing regions
vatsan-madhavan
force-pushed
the
5.0/speller-fixup
branch
from
5fc9747 to
5a554ff
Compare
vatsan-madhavan
force-pushed
the
5.0/speller-fixup
branch
from
5a554ff to
042322a
Compare
|
This issue seems like it is contributing to massive performance issues with the July .Net update, documented in #3350. This is one of very few issues that touched the relevant files. One other I found was #3092 |
This was referenced Aug 2, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPF's spell-checker on Win8+ ignores punctuations like
.(period) at the end of words likeetc.This results in well-formed words likeetc.,Mr.,Mrs.being marked as spelling-errors.Further, it is impossible to correct these words in WPF.
Because of the way word-breaking is performed by
MS.Data.Text.WordsSegmenterunder the hood, these punctuations are always dropped during word-breaking. The older spell-checker (NaturalLanguage6.dll) used on Win7 does not have this defect.MS.Data.Text.WordsSegmenterhas declined to 'fix'/'modify this behavior, so we are adding a workaround in WPF.This change introduces a wrapper on top of the word-breaker and recalculates the tokens, taking into account dropped text that occurs immediately after a token that is likely to fail spell-checking.
Note: See #2753 for the main discussion