Skip to content

[release/3.1] Update dependencies from dotnet/winforms #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2020
Merged

[release/3.1] Update dependencies from dotnet/winforms #3643

merged 1 commit into from
Oct 13, 2020

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 13, 2020

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • System.Reflection.MetadataLoadContext: from 4.7.2 to 4.7.2 (parent: Microsoft.NETCore.App.Runtime.win-x64)

From https://github.com/dotnet/winforms

  • Subscription: fd5f4619-cca3-4e12-8f56-08d72a4ce301
  • Build: 20201013.3
  • Date Produced: 10/13/2020 6:42 PM
  • Commit: af517511ca77d0aed7408e2ca712aa2b984d6ecb
  • Branch: refs/heads/release/3.1

@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
5e52cbe 
…01013.3

Microsoft.Private.Winforms
 From Version 4.8.1-servicing.20465.3 -> To Version 4.8.1-servicing.20513.3

Dependency coherency updates

System.Reflection.MetadataLoadContext
 From Version 4.7.2 -> To Version 4.7.2 (parent: Microsoft.NETCore.App.Runtime.win-x64
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Oct 13, 2020
@ghost ghost requested review from SamBent, fabiant3 and ryalanms October 13, 2020 18:50
@wtgodbe
Copy link
Member

wtgodbe commented Oct 13, 2020

@ryalanms lots of errors like:

F:\workspace_work\1\s\src\Microsoft.DotNet.Wpf\test\DRT\DrtXaml\DrtXaml\DrtXaml.csproj : error NU1201: Project System.Printing is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Project System.Printing supports: native (native,Version=v0.0) [F:\workspace_work\1\s\Microsoft.Dotnet.Wpf.sln]

F:\workspace_work\1\s\src\Microsoft.DotNet.Wpf\test\DRT\DrtXaml\DrtXaml\DrtXaml.csproj : error NU1201: Project DirectWriteForwarder is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Project DirectWriteForwarder supports: native (native,Version=v0.0) [F:\workspace_work\1\s\Microsoft.Dotnet.Wpf.sln]

Any ideas?

@ryalanms
Copy link
Member

ryalanms commented Oct 13, 2020

@mmitche provided a fix that I checked in as part of previous change: 3.1 needs to use the non-preview build machine pool.

It should pass if retried with the latest changes.

@wtgodbe
Copy link
Member

wtgodbe commented Oct 13, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 13, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-maestro dotnet-maestro bot merged commit 7e15333 into release/3.1 Oct 13, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-release/3.1-121dde3f-9f1d-4c3f-8835-2f07afb37ff1 branch October 13, 2020 23:09
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@ryalanms ryalanms Awaiting requested review from ryalanms

@SamBent SamBent Awaiting requested review from SamBent

Assignees

No one assigned

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wtgodbe @ryalanms