WPF ARM64: Update WPF Arcade SDK to support ARM64 #4040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com> Co-authored-by: Marcpems <marcpe@microsoft.com> Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com> Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com>
Co-authored-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com> Co-authored-by: Marcpems <marcpe@microsoft.com> Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com> Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com>
Member
Author
ryalanms
commented
Jan 20, 2021
ryalanms
commented
Jan 20, 2021
src/Microsoft.DotNet.Wpf/src/WpfGfx/core/hw/ShaderAssemblies.targets
Outdated
Show resolved
Hide resolved
ryalanms
force-pushed
the
Arm64.Wpf.Arcade.Sdk.Updates
branch
from
a23ce85 to
f1e97dd
Compare
azchohfi
approved these changes
Jan 20, 2021
hoyosjs
reviewed
Jan 20, 2021
Co-authored-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com> Co-authored-by: Marcpems <marcpe@microsoft.com> Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com> Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com>
ryalanms
force-pushed
the
Arm64.Wpf.Arcade.Sdk.Updates
branch
from
db67fb8 to
19af1cf
Compare
hoyosjs
reviewed
Jan 21, 2021
madewokherd
pushed a commit
to madewokherd/wpf
that referenced
this pull request
Mar 15, 2021
* Update WPF Arcade SDK to support ARM64 Co-authored-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com> Co-authored-by: Marcpems <marcpe@microsoft.com> Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com> Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com> * Update source files contained in the WPF Arcade SDK for ARM64 Co-authored-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com> Co-authored-by: Marcpems <marcpe@microsoft.com> Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com> Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com> * Use correct TFM. TFM should be win-arm64, not win10-arm64. Co-authored-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com> Co-authored-by: Marcpems <marcpe@microsoft.com> Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com> Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com> (cherry picked from commit fd6367d)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to the WPF Arcade SDK, both SDK props/targets and source files that ship with the WPF Arcade SDK.
The WPF Arcade SDK is consumed as a package dependency by WPF's internal repo. The WPF Arcade SDK updates must go in to the public WPF repo before the native ARM64 changes can be checked-in to the internal repo.
After this PR is submitted, verify the associated DARC update has been merged in WPF internal before merging the internal ARM64 changes.
Co-authored-by: Alexandre Zollinger Chohfi <...>
Co-authored-by: Marcpems <...>
Co-authored-by: Juan Sebastian Hoyos Ayala <...>
Co-authored-by: Ryland 41491307+ryalanms@users.noreply.github.com
#4034