Skip to content

Conversation

@batzen
Copy link
Contributor

@batzen batzen commented Feb 21, 2021

Fixes Issue #4172

Description

Converts the virtual internal property for ShouldShowOnKeyboardFocus to a public property and also adds a DependencyProperty for it.

Customer Impact

Tooltips always show on keyboard focus which is not the desired behavior in all customer applications.

@batzen batzen requested a review from a team as a code owner February 21, 2021 13:56
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Feb 21, 2021
@ghost ghost requested review from SamBent, fabiant3 and ryalanms February 21, 2021 13:56
@batzen
Copy link
Contributor Author

batzen commented Feb 21, 2021

ApiCompat will complain about the changes i made.
I don't know what has to be done to stop ApiCompat from complaining.

@batzen
Copy link
Contributor Author

batzen commented Feb 21, 2021

IMHO, this should also be backported to .NET 4.8.

@SamBent
Copy link
Contributor

SamBent commented Mar 1, 2021

@batzen - There is another round of tooltip accessibility changes on the way. We will include a proper solution to the extensibility issue you raised in #4172. (Your solution here isn't quite flexible enough.) So I'm closing this PR.

Changes to the public API surface cannot be backported to 4.8. Unfortunately that rules out any solution that introduces a new property or method - yours or mine. We'll add the extensibility point in .NET 6.0, but older versions are stuck with the current behavior.

@SamBent SamBent closed this Mar 1, 2021
@batzen
Copy link
Contributor Author

batzen commented Mar 3, 2021

@SamBent Could you be a bit more specific on why my solution isn't flexible enough?

Is there a chance that Microsoft could be more open/transparent about such upcoming changes?
Currently it feels like Microsoft alone decides what and how additions to WPF happen, and that doesn't feel very good to be honest.

Just to make sure i understand this correctly:
Microsoft changes the behavior in .NET 4.8, making it the new current, and says "now you are stuck with that as it's current"?
If behavior in .NET 4.8 can't be changed, why was the behavior changed in .NET 4.8?

@SamBent
Copy link
Contributor

SamBent commented Mar 4, 2021

See #4242

@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants