Fix ReachFramework's resource string resolution

[ryalanms]

Description

System.Windows.Documents.Serialization.SerializerProvider creation always fails while creating System.Uri.

SerializerProvider sp = new SerializerProvider();

at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
at System.Uri..ctor(String uriString)
at System.Windows.Xps.Serialization.XpsSerializerFactory.get_ManufacturerWebsite()
at System.Windows.Documents.Serialization.SerializerDescriptor.CreateFromFactoryInstance(ISerializerFactory factoryInstance)
at System.Windows.Documents.Serialization.SerializerProvider..ctor()
at TestSerializerProvider.MainWindow..ctor() in D:\PluginSerializer\TestSerializerProvider\MainWindow.xaml.cs:line 30

The issue is that resource lookups for the ReachFramework were not actually resolving the string, and instead were returning the key. When the key Xps_ManufacturersWebsite was passed in to the URI constructor, URI creation failed. Fixing the resource lookup path fixed SerializerProvider. Fixes #4481.

This bug is blocking testing of the fix for another bug that is preventing WPF from taking the latest WinForms update: #4479.

Regression

No. This is a longstanding bug from 3.0.

Testing

Repro'd the failure, fixed the resource string lookup, and verified SerializerProvider is working.

[SamBent]

I trust you've checked all the other SR.cs files for the same problem?

[ryalanms]

I trust you've checked all the other SR.cs files for the same problem?

Thanks, Sam. Yes, the other eleven SR.cs files are correct. ReachFramework is the only component that was not calling GetResourceString before Format.