Skip to content

Conversation

@vishalmsft
Copy link
Contributor

The copy operation using PowerShell script was a quick setup for developer to debug WPF project locally.

Description

Developer Guide: Added section Debugging locally build WPF assemblies with WPF Application. The section explains, what changes are required in CSPROJ, which is configured to consume the WPF project. The steps are simplified by adding a wpf-debug.targets file.

Targets file: This is just to simplify the setting up of the project consuming WPF. Instead of using installed assemblies, the project will use assemblies built using this project.

Customer Impact

This presents ease of setup for the developers.

Testing

Tested using guidelines added in Developer Guide.

@vishalmsft vishalmsft requested a review from a team as a code owner May 25, 2021 09:56
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label May 25, 2021
@ghost ghost requested review from SamBent, fabiant3 and ryalanms May 25, 2021 09:56
@dnfadmin
Copy link

dnfadmin commented May 25, 2021

CLA assistant check
All CLA requirements met.

-->

<PropertyGroup>
<WpfConfig>Debug</WpfConfig>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<WpfConfig>Debug</WpfConfig>
<WpfConfig Condition="'$(WpfConfig)'==''">$(Configuration)</WpfConfig>

@ThomasGoulet73 How about the default is $(Configuration)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picking up the default of consuming project is reasonable, when, SDK and Project, both build on configuration change. That is not true in this case.

Set WpfConfig, only if consuming project haven't set it.

Co-authored-by: ThomasGoulet73 <51839772+ThomasGoulet73@users.noreply.github.com>
@singhashish-wpf singhashish-wpf merged commit 55bce96 into main Sep 29, 2021
@vishalmsft vishalmsft deleted the developer-guide-targetfile branch October 20, 2021 08:43
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants