Skip to content

Conversation

@Nirmal4G
Copy link
Contributor

@Nirmal4G Nirmal4G commented Jun 4, 2021

  • Fixup new-lines
  • Remove trailing white-space
  • Respect EditorConfig preferences

@Nirmal4G Nirmal4G requested a review from a team as a code owner June 4, 2021 13:31
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 4, 2021
@ghost ghost requested review from SamBent, fabiant3 and ryalanms June 4, 2021 13:31
@Nirmal4G Nirmal4G force-pushed the hotfix/format-WinFX-targets branch from 748bf51 to 1a62e68 Compare August 26, 2021 08:41
@Nirmal4G Nirmal4G changed the base branch from main to release/6.0 August 26, 2021 16:27
@Nirmal4G
Copy link
Contributor Author

This is fairly a simple one, I think! 🤔

So, can someone/anyone (please) take a look at this patch at priority? 🧐

@Nirmal4G Nirmal4G force-pushed the hotfix/format-WinFX-targets branch from 1a62e68 to 59c46f9 Compare September 1, 2021 17:57
@ryalanms ryalanms changed the base branch from release/6.0 to main September 3, 2021 20:50
@ryalanms
Copy link
Member

ryalanms commented Sep 3, 2021

The 6.0 branch is closed for check-ins. This needs to go in to 7.0 (main).

Only in 'Microsoft.WinFX.targets' file
Respect EditorConfig preferences for whitespace and new-lines
@Nirmal4G Nirmal4G force-pushed the hotfix/format-WinFX-targets branch from 59c46f9 to 07ff83c Compare September 4, 2021 12:15
@Nirmal4G
Copy link
Contributor Author

Nirmal4G commented Sep 4, 2021

@ryalanms Rebase done. This is fairly a non-breaking/no-code-change patch, why it didn't qualify for v6 branch?

@ryalanms
Copy link
Member

ryalanms commented Sep 8, 2021

Thanks, @Nirmal4G. Nothing is going in to 6.0 at this stage other than a small set of pre-approved changes (Intellisense, localization, etc.)

@ryalanms ryalanms merged commit bd8c751 into dotnet:main Sep 8, 2021
@Nirmal4G Nirmal4G deleted the hotfix/format-WinFX-targets branch September 8, 2021 18:27
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants