Skip to content

Conversation

@jonfortescue
Copy link
Contributor

Description

Currently OneLocBuild does not automatically make PRs back to GitHub. This will make it automatically make PRs back to GitHub. Documentation here.

Customer Impact

Customers will be able to use WPF in languages other than English.

Regression

No.

Testing

N/A

Risk

PRs may be noisy. If this occurs, please file an issue with the localization team.

@jonfortescue jonfortescue requested a review from a team as a code owner June 16, 2021 20:08
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 16, 2021
@ghost ghost requested review from SamBent, fabiant3 and ryalanms June 16, 2021 20:08
@jonfortescue jonfortescue self-assigned this Jun 16, 2021
@jonfortescue jonfortescue merged commit a949215 into dotnet:main Jun 21, 2021
@jonfortescue jonfortescue deleted the TurnOnLocPRs branch June 21, 2021 16:57
@ryalanms
Copy link
Member

ryalanms commented Jun 23, 2021

@jonfortescue: Who will review all of the PRs that are being created by this change? Should these be auto-merged?

/cc @dotnet/wpf-developers

@jonfortescue
Copy link
Contributor Author

@ryalanms they should be reviewed by repository owners to make sure there isn't something super weird (like translations are being deleted or non-xlf files are being changed) and then merged.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants