Skip to content

Remove delegate/array allocations from EventMap.NotifySources #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Remove delegate/array allocations from EventMap.NotifySources #4756

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90b84f3
Remove delegate/closure/array allocations from EventMap.NotifySources
stephentoub Jun 25, 2021
bdb07d0
Merge branch 'main' into eventmapnotify
ryalanms Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/Automation/EventMap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,27 +269,23 @@ private static void NotifySources()
{
if (!source.IsDisposed)
{
source.Dispatcher.BeginInvoke(DispatcherPriority.Normal,
new DispatcherOperationCallback(NotifySource),
new object[]{source});
source.Dispatcher.BeginInvoke(DispatcherPriority.Normal, (DispatcherOperationCallback)(state =>
{
PresentationSource source = (PresentationSource)state;
if (source != null && !source.IsDisposed)
{
// setting the RootVisual to itself triggers the logic to
// add to the AutomationEvents list
source.RootVisual = source.RootVisual;
}
return null;
}), source);
}
}
}

private static object NotifySource(Object args)
{
object[] argsArray = (object[])args;
PresentationSource source = argsArray[0] as PresentationSource;
if (source != null && !source.IsDisposed)
{
// setting the RootVisual to itself triggers the logic to
// add to the AutomationEvents list
source.RootVisual = source.RootVisual;
}
return null;
}

private static Dictionary<int, EventInfo> _eventsTable; // key=event id, data=listener count
private readonly static object _lock = new object();
}
}