Remove unneeded Directory.Build.props file #4778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file does nothing, and its existence prevents GitHub from collapsing the src/Microsoft.DotNet.Wpf subdirectory into one link, which IMO greatly enhances navigation of this repo on GitHub.com.
ghost
added
the
ghost
requested review from
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This file does nothing (MSBuild will evaluate the same way without it), and its existence prevents GitHub from collapsing the src/Microsoft.DotNet.Wpf subdirectory into one link.
Customer Impact
Developers will be able to enter the src/Microsoft.DotNet.Wpf subdirectory from the repo homepage with one click, rather than having to click into the src subdirectory and then into Microsoft.DotNet.Wpf. I find this latter behavior very annoying whenever I browse the WPF repo on GitHub.