Skip to content

Conversation

@SamBent
Copy link
Contributor

@SamBent SamBent commented Jul 2, 2021

  • Add API spec template
  • Cosmetic changes to ToolTip spec, to bring it closer to the new template, clarify some wording, and fix one glaring typo.
  • Revise instructions for API-compat and GenAPI
  • Disable api-compat checks during a gen-api build. This has to be done anyway, so it should be built in.

This PR does not change any product code.

@SamBent SamBent requested a review from a team as a code owner July 2, 2021 18:43
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 2, 2021
@ghost ghost requested review from fabiant3 and ryalanms July 2, 2021 18:43
<!-- Only enable Ref API Compat for the lib projects using hand-crafted reference assemblies -->
<PropertyGroup Condition="'$(RunRefApiCompat)'==''">
<!-- Only enable Ref API Compat for the lib projects using hand-crafted reference assemblies,
but not if we're generating the reference assemblies -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: $(GenerateReferenceAssemblySource)'!='true' for when it is explicitly false.

@SamBent SamBent merged commit 920b0b0 into dotnet:main Jul 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants