Skip to content

Clean up yaml and add internal runtime download #4805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2021
Merged

Clean up yaml and add internal runtime download #4805

merged 1 commit into from
Jul 9, 2021

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Jul 6, 2021

  • Remove some unused variables and unused yaml
  • Fix up the internal runtime download args so they are always present when running on the internal project

@mmitche mmitche requested a review from a team as a code owner July 6, 2021 18:47
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 6, 2021
@ghost ghost requested review from SamBent, fabiant3 and ryalanms July 6, 2021 18:47
@mmitche
Copy link
Member Author

mmitche commented Jul 6, 2021

Official build test: https://dev.azure.com/dnceng/internal/_build/results?buildId=1222234&view=results
Internal PR test: https://dev.azure.com/dnceng/internal/_build/results?buildId=1222121&view=logs&j=ff5997a9-eb9c-5c99-9be7-35e8f687ef03

@RussKie RussKie merged commit ab1e156 into dotnet:main Jul 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@ryalanms ryalanms Awaiting requested review from ryalanms

@SamBent SamBent Awaiting requested review from SamBent

Assignees

No one assigned

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmitche @RussKie