Revert "Remove analyzers from framework references" #4885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1400177.
ghost
added
the
ghost
requested review from
ericstj
added
the
* NO MERGE *
Member
Author
|
Fixes #4848 |
ericstj
removed
the
* NO MERGE *
Member
Author
|
I have reviewed the binlogs and the issue no longer exists, so this should be good to go. Can I get a review @ryalanms? |
ryalanms
approved these changes
Jul 20, 2021
Member
|
Thank you, @ericstj! |
Member
|
/cc @dotnet/wpf-developers |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4849
This should no longer needed now that WPF is consuming an RC SDK. Don't merge this until we manually validate the C++/CLI binaries don't have references to the JSON source generator (since that would only fail after ingestion upstack).