Skip to content

Conversation

@SamBent
Copy link
Contributor

@SamBent SamBent commented Jul 21, 2021

Description

Fixing two problems with the recent work to support new UIA events (#4850):

  1. New events were not delivered to client-side code. More precisely, UIA delivers the events to our internal client-side listener, but it lacked the plumbing needed to forward the event to user client-side listeners (decoding the event type, converting event args from native to managed, etc.).
  2. The TextRange argument to the ActiveTextPositionChanged event was set to a raw ITextRangeProvider, instead of a wrapper.

Customer Impact

  1. Managed clients don't receive the new events.
  2. An ActiveTextPositionChanged listener that calls one of the ITextRangeProvider methods crashes the target app.

Regression

Problems only affect usage of the new events.

Testing

Ad-hoc. New test cases are being added.

Risk

These fixes are required.

@SamBent SamBent requested a review from a team as a code owner July 21, 2021 18:25
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 21, 2021
@ghost ghost requested review from fabiant3 and ryalanms July 21, 2021 18:25
@SamBent SamBent merged commit cb6ed2c into dotnet:main Jul 23, 2021
@SamBent SamBent deleted the UIAEventClient branch July 23, 2021 20:52
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants