Replace and remove IL injection in PresentationCore #4911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
Member
Author
|
global.json and versions.props still need to be updated. |
rladuca
reviewed
Jul 23, 2021
SamBent
approved these changes
Jul 23, 2021
Member
|
lgtm. Have you checked IL-diff's before vs after that everthing looks good? |
…Otherwise fix version to 10.
…nto remove.il.injection
vatsan-madhavan
approved these changes
Jul 26, 2021
Member
vatsan-madhavan
left a comment
vatsan-madhavan
left a comment
There was a problem hiding this comment.
Looked at IL-diff with @ryalanms over Teams - changes look good 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module initializers are now supported with a single attribute. As a prerequisite to updating the WPF repo to build against C# 10, this change adds the single ModuleInitializer attribute to PresentationCore and removes the IL injection logic from the WPF repo.
The module initializer without IL injection is working as expected:
Prior to C# 9, the PresentationCore assembly was built, disassembled to IL, combined with additional IL containing a module initializer, and reassembled to a final PresentationCore assembly.
Related:
#3885
#4748
#4889
/cc @rladuca @vatsan-madhavan @SamBent