Skip to content

Localization request for WPF templates #5078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2021
Merged

Localization request for WPF templates #5078

merged 1 commit into from
Aug 16, 2021

Conversation

@ryalanms
Copy link
Member

@ryalanms ryalanms commented Aug 16, 2021 •
edited
Loading

Use the new Microsoft.TemplateEngine.TemplateLocalizer to create localization files and request for the following WPF templates:

WpfApplication-CSharp
WpfApplication-VisualBasic
WpfClassLibrary-CSharp
WpfClassLibrary-VisualBasic
WpfCustomControlLibrary-CSharp
WpfCustomControlLibrary-VisualBasic
WpfUserControlLibrary-CSharp
WpfUserControlLibrary-VisualBasic

This is a required step to fix #3663.

@ryalanms ryalanms requested a review from a team as a code owner August 16, 2021 17:49
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Aug 16, 2021
@ghost ghost requested review from SamBent and fabiant3 August 16, 2021 17:49
@ryalanms
Copy link
Member Author

ryalanms commented Aug 16, 2021

@dotnet/wpf-developers: This needs to be submitted before the remaining localization work can be completed.

@ryalanms ryalanms merged commit 327be36 into main Aug 16, 2021
@vishalmsft vishalmsft deleted the localize.templates.with.template-localizer branch February 10, 2022 06:04
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@vlada-shubina vlada-shubina Awaiting requested review from vlada-shubina

@phenning phenning Awaiting requested review from phenning

@cristianosuzuki77 cristianosuzuki77 Awaiting requested review from cristianosuzuki77

1 more reviewer

@SamBent SamBent SamBent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add localization support for CLI templates

3 participants

@ryalanms @SamBent