Skip to content

Conversation

@ryalanms
Copy link
Member

@ryalanms ryalanms commented Oct 5, 2021

Description

[release/6.0] Overbuild caused by PackageReference support (Remove WPF Arcade workaround)

WPF PackageReference support conflicted with an existing Arcade workaround. The WPF workaround (for the Arcade workaround) changed a global property that caused project references to be rebuilt in WPF's temporary project.

This removes the global property.

The issue is described here:
#5448
#4119

Customer Impact

Project references will be built a second time by the internal WPF project.

Regression

This is a regression from 5.0.

Risk

Low.

Testing

Tested the updated WindowsDesktop SDK containing the change against AppCompat applications and WPF samples.

@ryalanms ryalanms requested a review from a team as a code owner October 5, 2021 20:19
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Oct 5, 2021
@ghost ghost requested review from SamBent and fabiant3 October 5, 2021 20:19
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good.

I'm not sure I understand the order dependencies though. In the end we want three things to happen:

  1. This goes into the shipping product.
  2. The Arcade SDK workaround is removed.
  3. All repos that use the Arcade SDK are updated to use a .NET SDK that has this fix.

Can we do 1 and 2 in parallel? Or will doing 2 break other repos unless they also get 3?

@ryalanms
Copy link
Member Author

ryalanms commented Oct 5, 2021

Can we do 1 and 2 in parallel? Or will doing 2 break other repos unless they also get 3?

The repos will break if they update to the .NET SDK with the WPF fix, prior to updating to the Arcade SDK with the fix. But I believe both 1 and 2 can be done simultaneously if the version updates are done in the correct order (or together).

@ryalanms
Copy link
Member Author

ryalanms commented Oct 7, 2021

The PR build won't succeed until WPF takes the Arcade SDK version containing the fix.

@ryalanms ryalanms force-pushed the remove.arcade.workaround branch from 1b360d6 to 8804eec Compare October 7, 2021 17:46
@ryalanms
Copy link
Member Author

ryalanms commented Oct 7, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryalanms ryalanms changed the title Overbuild caused by PackageReference support (Remove WPF Arcade workaround) [release/6.0] Overbuild caused by PackageReference support (Remove WPF Arcade workaround) Oct 8, 2021
@ryalanms
Copy link
Member Author

ryalanms commented Oct 9, 2021

The Arcade SDK update has already flowed to all repos.

@ryalanms
Copy link
Member Author

ryalanms commented Oct 11, 2021

This was approved by Tactics over email.

@ryalanms ryalanms added this to the 6.0.0 milestone Oct 11, 2021
@ryalanms ryalanms merged commit 388f13d into release/6.0 Oct 11, 2021
@vishalmsft vishalmsft deleted the remove.arcade.workaround branch February 15, 2022 05:34
@ghost ghost locked as resolved and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage Servicing-approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants