-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[release/6.0] Overbuild caused by PackageReference support (Remove WPF Arcade workaround) #5453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rainersigwald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good.
I'm not sure I understand the order dependencies though. In the end we want three things to happen:
- This goes into the shipping product.
- The Arcade SDK workaround is removed.
- All repos that use the Arcade SDK are updated to use a .NET SDK that has this fix.
Can we do 1 and 2 in parallel? Or will doing 2 break other repos unless they also get 3?
The repos will break if they update to the .NET SDK with the WPF fix, prior to updating to the Arcade SDK with the fix. But I believe both 1 and 2 can be done simultaneously if the version updates are done in the correct order (or together). |
|
The PR build won't succeed until WPF takes the Arcade SDK version containing the fix. |
1b360d6 to
8804eec
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The Arcade SDK update has already flowed to all repos. |
|
This was approved by Tactics over email. |
Description
[release/6.0] Overbuild caused by PackageReference support (Remove WPF Arcade workaround)
WPF PackageReference support conflicted with an existing Arcade workaround. The WPF workaround (for the Arcade workaround) changed a global property that caused project references to be rebuilt in WPF's temporary project.
This removes the global property.
The issue is described here:
#5448
#4119
Customer Impact
Project references will be built a second time by the internal WPF project.
Regression
This is a regression from 5.0.
Risk
Low.
Testing
Tested the updated WindowsDesktop SDK containing the change against AppCompat applications and WPF samples.