[main] Update dependencies from dotnet/arcade #5733

dotnet-maestro · 2021-11-24T13:19:12Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Subscription: 840bf684-917a-4879-f62c-08d8e93a0c51
Build: 20211210.4
Date Produced: December 10, 2021 11:07:13 PM UTC
Commit: 18adc5b47acce8bb03948baf578fca442d1029d4
Branch: refs/heads/main

Updates:
- Microsoft.DotNet.Arcade.Sdk: from 7.0.0-beta.21569.2 to 7.0.0-beta.21610.4
- Microsoft.DotNet.ApiCompat: from 7.0.0-beta.21569.2 to 7.0.0-beta.21610.4
- Microsoft.DotNet.CodeAnalysis: from 7.0.0-beta.21569.2 to 7.0.0-beta.21610.4
- Microsoft.DotNet.GenAPI: from 7.0.0-beta.21569.2 to 7.0.0-beta.21610.4
- Microsoft.DotNet.Helix.Sdk: from 7.0.0-beta.21569.2 to 7.0.0-beta.21610.4

…123.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21573.3

…124.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21574.3

RussKie · 2021-11-26T02:33:17Z

/cc: @jonfortescue @lukas-lansky @MattGal - WPF fails to build on VS2019, likely need VS2022, https://github.com/dotnet/core-eng/issues/14640

…126.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21576.2

…126.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21576.4

MattGal · 2021-11-29T18:26:37Z

/cc: @jonfortescue @lukas-lansky @MattGal - WPF fails to build on VS2019, likely need VS2022, dotnet/core-eng#14640

Taking a look.

…2 for WPF's purposes.

MattGal · 2021-11-29T18:45:12Z

@RussKie I think this is just a check that got introduced in the GA version of 6.0.100 SDK, I went ahead and put you on the VS 2022 versions of the same images and I'll keep an eye on it.

MattGal · 2021-11-29T19:05:21Z

@RussKie looks like we may need to add more workloads. A bunch got added here: https://github.com/dotnet/core-eng/issues/15030 (this change rolls out this Weds, 12/1/2021) but I'm not sure we have all the ones you need.

Would you mind listing the workloads exported from a VS 2022 Enterprise machine on a machine that can successfully build your solution(s)?

RussKie · 2021-11-30T00:38:20Z

@MattGal does this help?
https://github.com/dotnet/wpf/blob/main/Documentation/wpf.vsconfig

MattGal · 2021-11-30T01:12:59Z

@MattGal does this help? https://github.com/dotnet/wpf/blob/main/Documentation/wpf.vsconfig

It super does. It may be a bit before we can help you there though. You can choose to delay this arcade update (I am unaware of any hot fresh things coming in with this specific flow that you actually need) or tweak it to keep using pre-release SDKs that allowed this to work from before at your discretion.

singhashish-wpf · 2021-12-02T04:21:31Z

/azp run

azure-pipelines · 2021-12-02T04:21:40Z

Azure Pipelines successfully started running 1 pipeline(s).

RussKie · 2021-12-02T07:05:05Z

This seems related: https://teams.microsoft.com/l/message/19:1dad2081c8634f34915d88dce6220265@thread.skype/1638290105144?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4d73664c-9f2f-450d-82a5-c2f02756606d&parentMessageId=1638284188026&teamName=.NET%20Core%20Eng%20Services%20Partners&channelName=Arcade&createdTime=1638290105144

vishalmsft · 2021-12-02T09:08:06Z

This PR is already on VS2022. May be missing use of wpf.config, as, CPP compilation support is missing.
Errors are at
Preview\MSBuild\Microsoft\VC\v170\Microsoft.Cpp.CppWinRT.props"

/cc: @singhashish-wpf

singhashish-wpf · 2021-12-02T12:57:06Z

From the workloads issue/PR https://github.com/dotnet/core-eng/issues/15057
It seems that Microsoft.Component.VC.Runtime.UCRTSDK isn't added as it does not exist for VS2022 and the build error after changing the pool to VS2022 looks to be because of that.
https://dev.azure.com/dnceng/public/_build/results?buildId=1493510&view=logs&j=ff5997a9-eb9c-5c99-9be7-35e8f687ef03&t=5db218e6-61df-5548-59cd-3f58379906e8&l=74

@lpatalas @MattGal Any ideas on how to get this going like including UCRTSDK for VS2022 or any replacements?

lpatalas · 2021-12-02T15:24:13Z

@singhashish-wpf Just to be clear https://github.com/dotnet/core-eng/issues/15057 is not rolled out yet. We've merged the PR yesterday but it didn't make it into the rollout. We plan to roll it out next Wednesday.

And regarding Microsoft.Component.VC.Runtime.UCRTSDK - it's not listed at Visual Studio Enterprise component directory but I'm not sure what to do about it. If we should replace it with some other workload then just let me know and I'll include it in the list.

MattGal · 2021-12-02T16:09:15Z

@singhashish-wpf Just to be clear dotnet/core-eng#15057 is not rolled out yet. We've merged the PR yesterday but it didn't make it into the rollout. We plan to roll it out next Wednesday.

And regarding Microsoft.Component.VC.Runtime.UCRTSDK - it's not listed at Visual Studio Enterprise component directory but I'm not sure what to do about it. If we should replace it with some other workload then just let me know and I'll include it in the list.

Came here to say this, but one important thing to note also is that you can try the "-Int" versions of the 1ES pool provider to see if this image is sufficient for you today. (please don't merge changes depending on these unless you want to be randomly broken in the future), i.e. "NetCore1ESPool-Public-Int" / "NetCore1ESPool-Internal-Int". Doing it this way prevents a week-long cycle of noticing you needed "just one more thing"

singhashish-wpf · 2021-12-03T03:40:50Z

The error regarding Microsoft.Cpp.CppWinRT.props remains the same even after changing to 1ES pool Int provider.

This reverts commit 266cd39.

…202.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21602.3

ThomasGoulet73 · 2021-12-03T19:18:11Z

@singhashish-wpf You could try updating PlatformToolset to v143 instead of v142 (Defined here). Then it shouldn't import C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Microsoft\VC\v160\Platforms\{Platform}\ImportBefore\Microsoft.Cpp.CppWinRT.props which wouldn't try to import C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Microsoft\VC\v170\Microsoft.Cpp.CppWinRT.props. I don't think C++/WinRT is used in this repo so this shouldn't cause a problem.

…203.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21603.6

…s://github.com/dotnet/wpf into darc-main-83d344b6-2da4-4cb4-bc09-b0c292dfa886

ThomasGoulet73 · 2021-12-04T17:44:34Z

Sorry, I forgot to mention that you also need to update these lines: https://github.com/dotnet/wpf/blob/main/src/Microsoft.DotNet.Wpf/redist/VCRuntime/VCRuntime.vcxproj#L36-L37

singhashish-wpf · 2021-12-07T06:25:59Z

/azp run

azure-pipelines · 2021-12-07T06:26:09Z

Azure Pipelines successfully started running 1 pipeline(s).

…206.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21606.6

singhashish-wpf · 2021-12-07T16:34:44Z

@MattGal @lpatalas Any pointers on atls.lib error? It seems because of the machine state as for me the build is passing locally...

MattGal · 2021-12-07T16:41:55Z

@MattGal @lpatalas Any pointers on atls.lib error? It seems because of the machine state as for me the build is passing locally...

Taking a look, there's also the @dotnet/dnceng alias in case Lukasz or I are unavailable

mmitche · 2021-12-07T16:48:19Z

@MattGal @lpatalas Any pointers on atls.lib error? It seems because of the machine state as for me the build is passing locally...

Taking a look, there's also the @dotnet/dnceng alias in case Lukasz or I are unavailable

This is because an LTCG-built lib is used cross repo and this particular lib was built using a different version of the compiler than what is in use in this build (the LTCG object format is more strongly tied to compiler version vs. a static library).

dotnet-wpf-int needs to be re-built on the same pool this is running on, and flowed to this repo.

singhashish-wpf · 2021-12-09T11:14:39Z

/azp run

azure-pipelines · 2021-12-09T11:14:50Z

Azure Pipelines successfully started running 1 pipeline(s).

…208.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21608.1

…209.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21609.2

…210.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21610.4

dotnet-maestro bot requested a review from a team as a code owner November 24, 2021 13:19

ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 24, 2021

ghost requested review from SamBent, fabiant3 and ryalanms November 24, 2021 13:19

dotnet-maestro bot added 2 commits November 26, 2021 13:18

Update image used; it seems the GA 6.0.100 .NET Core SDK wants VS 202…

2206d6c

…2 for WPF's purposes.

singhashish-wpf self-assigned this Dec 1, 2021

Temporarily change to Int pools for verification

266cd39

singhashish-wpf and others added 2 commits December 3, 2021 09:11

Revert "Temporarily change to Int pools for verification"

2664054

This reverts commit 266cd39.

singhashish-wpf added 2 commits December 4, 2021 22:41

Change platform Toolset to 143

7ac6d55

Merge branch 'darc-main-83d344b6-2da4-4cb4-bc09-b0c292dfa886' of http…

1434779

…s://github.com/dotnet/wpf into darc-main-83d344b6-2da4-4cb4-bc09-b0c292dfa886

singhashish-wpf added 3 commits December 6, 2021 08:11

Update VCRuntime VC version

d28bc44

Temporarily change pool to internal

ca9f2fe

Change toolsversion to 17

64f0a14

singhashish-wpf and others added 2 commits December 7, 2021 14:44

temporarily remove atl lib dependency

c32bf9a

vishalmsft mentioned this pull request Dec 9, 2021

Update Wpf.Cpp.props to use VS2022 for cpp compilation #5803

Closed

dotnet-maestro bot added 2 commits December 10, 2021 13:19

dotnet-maestro bot merged commit 8238324 into main Dec 11, 2021

dotnet-maestro bot deleted the darc-main-83d344b6-2da4-4cb4-bc09-b0c292dfa886 branch December 11, 2021 13:48

ghost locked as resolved and limited conversation to collaborators Apr 6, 2022

[main] Update dependencies from dotnet/arcade #5733

[main] Update dependencies from dotnet/arcade #5733

Uh oh!

Conversation

dotnet-maestro bot commented Nov 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/arcade

Uh oh!

RussKie commented Nov 26, 2021

Uh oh!

MattGal commented Nov 29, 2021

Uh oh!

MattGal commented Nov 29, 2021

Uh oh!

MattGal commented Nov 29, 2021

Uh oh!

RussKie commented Nov 30, 2021

Uh oh!

MattGal commented Nov 30, 2021

Uh oh!

singhashish-wpf commented Dec 2, 2021

Uh oh!

azure-pipelines bot commented Dec 2, 2021

Uh oh!

RussKie commented Dec 2, 2021

Uh oh!

vishalmsft commented Dec 2, 2021

Uh oh!

singhashish-wpf commented Dec 2, 2021

Uh oh!

lpatalas commented Dec 2, 2021

Uh oh!

MattGal commented Dec 2, 2021

Uh oh!

singhashish-wpf commented Dec 3, 2021

Uh oh!

ThomasGoulet73 commented Dec 3, 2021

Uh oh!

ThomasGoulet73 commented Dec 4, 2021

Uh oh!

singhashish-wpf commented Dec 7, 2021

Uh oh!

azure-pipelines bot commented Dec 7, 2021

Uh oh!

singhashish-wpf commented Dec 7, 2021

Uh oh!

MattGal commented Dec 7, 2021

Uh oh!

mmitche commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

singhashish-wpf commented Dec 9, 2021

Uh oh!

azure-pipelines bot commented Dec 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

dotnet-maestro bot commented Nov 24, 2021 •

edited

Loading

mmitche commented Dec 7, 2021 •

edited

Loading