Build on VS 2022 #5804
Closed
Build on VS 2022 #5804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
Contributor
|
@singhashish-wpf it will be good idea to first take the changes from eng/WpfArcadeSdk/tools/Wpf.Cpp.props . Let build publish the packages and then move to VS2022. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| <PropertyGroup> | ||
| <VCRedistCrtFolderName Condition="'$(Configuration)'=='Release'">Microsoft.VC142.CRT</VCRedistCrtFolderName> | ||
| <VCRedistCrtFolderName Condition="'$(Configuration)'=='Debug'">Microsoft.VC142.DebugCRT</VCRedistCrtFolderName> | ||
| <VCRedistCrtFolderName Condition="'$(Configuration)'=='Release'">Microsoft.VC143.CRT</VCRedistCrtFolderName> |
Contributor
There was a problem hiding this comment.
Is the fallback still necessary ?
wpf/src/Microsoft.DotNet.Wpf/redist/VCRuntime/VCRuntime.vcxproj
Lines 38 to 42 in af9ff74
It seems weird to fallback to VC141 when VC143 does not exist.
Contributor
Author
There was a problem hiding this comment.
Not necessary @ThomasGoulet73
Will be removed.
Contributor
Author
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Build on VS 2022
Main PR
Description
Customer Impact
Regression
Testing
Risk