Port UIA_WindowVisibilityOverridden fix from 4.8 #5839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
dipeshmsft
approved these changes
Jan 4, 2022
dipeshmsft
added a commit
that referenced
this pull request
Feb 7, 2022
dipeshmsft
added a commit
that referenced
this pull request
Feb 7, 2022
dipeshmsft
pushed a commit
that referenced
this pull request
Feb 7, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5443
This is a port of a servicing fix in .NET 4.7-4.8.
Description
This bug is about "anomalous" windows, where the UIA_WindowVisibilityOverridden property is set to 1 (ForceVisible), but window's rect is empty. The .NET automation code doesn't recognize this property, and thus treats the window as "not visible" because it's empty. This means an automation search won't find any windows below the anomalous window.
Fixed by recognizing the property, and overriding the hwnd's visibility to automation accordingly.
Customer Impact
Automation searches cannot find descendants of anomalous windows (e.g. the Windows 11 Start button).
Regression
No.
Testing
Ad-hoc around customer scenario.
Standard regression testing.
Risk
Low. Port of a .NETFx servicing fix released earlier this year.