Use builtin MSBuild functions to compare versions #5910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
singhashish-wpf
approved these changes
Jan 5, 2022
Contributor
|
Nice! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Future-proofs target framework version increments by using builtin MSBuild functions to compare target framework versions.
Reduces the number of place to update when incrementing the target framework version.
This PR could be merged before #5901 to reduce diff or after to reduce diff of future target framework version increments.
The changes in this PR requires MSBuild 16.5 since
VersionGreaterThanOrEqualswas added in this version.Customer Impact
Build only.
Regression
No.
Testing
Local build + CI.
Risk
None.
/cc @singhashish-wpf @RussKie