Use ArgumentOutOfRangeException.ThrowIf* across codebase #8403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
ghost
requested review from
a bug in the fixer?
halgab
commented
Nov 8, 2023
| { | ||
| throw new ArgumentOutOfRangeException("timeout"); | ||
| } | ||
| ArgumentOutOfRangeException.ThrowIfEqual(timeout, Duration.Automatic); |
Contributor
Author
There was a problem hiding this comment.
I had to roll this back because Duration does not implement IEquatable. That would make sense though, and would be trivial to implement
rchauhan18
approved these changes
Nov 27, 2023
rchauhan18
added
Queue for test pass
Included in test pass
and removed
Queue for test pass
labels
Contributor
|
Thanks @halgab for contributing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
ArgumentOutOfRangeException.ThrowIf*across codebase. A lot of potential use cases are not covered yet because CA1512 cannot automatically take care of them thoughRegression
No
Testing
CI
Risk
Low. We use fixer CA1512
Microsoft Reviewers: Open in CodeFlow