More uses of ArgumentOutOfRangeException.ThrowIf* to replace custom error messages #8489
Conversation
ghost
assigned
ghost
requested review from
|
Awesome, thank you @halgab for your contribution. |
halgab
force-pushed
the
aoore-helpers-4
branch
from
ba81218 to
4648142
Compare
| ParameterMustBeGreaterThanZero=The parameter value must be greater than zero. | ||
| ParameterCannotBeLessThan=The parameter value cannot be less than '{0}'. | ||
| ParameterCannotBeGreaterThan=The parameter value cannot be greater than '{0}'. | ||
| ParameterMustBeBetween=The parameter value must be between '{0}' and '{1}'. |
There was a problem hiding this comment.
I guess I should clean up the other lines corresponding to the resources I removed in my previous PR. Should I do it here?
There was a problem hiding this comment.
Yes, you can remove the lines here.
| { | ||
| throw new System.ArgumentOutOfRangeException("value", SR.Format(SR.ParameterMustBeBetween, 1, 255)); | ||
| } | ||
| ArgumentOutOfRangeException.ThrowIfZero(value); |
There was a problem hiding this comment.
As a byte, value cannot be negative or greater than 255
| } | ||
| set | ||
| { | ||
| if ((value < 0) || (value > 3)) |
There was a problem hiding this comment.
As a byte, value cannot be negative
| } | ||
| set | ||
| { | ||
| if ((value < 0) || (value > 2)) |
There was a problem hiding this comment.
As a byte, value cannot be negative
| if ((value < 0) || (value > 255)) | ||
| { | ||
| throw new System.ArgumentOutOfRangeException("value", SR.Format(SR.ParameterMustBeBetween, 0, 255)); | ||
| } | ||
|
|
There was a problem hiding this comment.
As a byte, value cannot be negative or greater than 255, so this check is redundant
| } | ||
| set | ||
| { | ||
| if ((value < 0) || (value > 3)) |
There was a problem hiding this comment.
As a byte, value cannot be negative
| } | ||
| set | ||
| { | ||
| if ((value < 0) || (value > 4)) |
There was a problem hiding this comment.
As a byte, value cannot be negative
halgab
changed the title
|
Thanks @halgab for the contribution! |
4 participants
Follow-up to #8408
Description
As mentioned in #8408, ParameterMustBeBetween, ParameterValueCannotBeInfinity and ParameterValueCannotBeNaN are good candidates for replacing custom ressources with inbox ones. This PR addresses those two cases, each in its own commit
Regression
No
Testing
CI
Risk
Low. I manually searched and removed the error messages, and let CA1512 finish the work
Microsoft Reviewers: Open in CodeFlow