Converting templates to 1ES PT #8892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
PR
Contributor
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lonitra
reviewed
Mar 14, 2024
Member
lonitra
left a comment
lonitra
left a comment
There was a problem hiding this comment.
minor comments about cleaning up conditions checking public vs internal, but otherwise awesome work! 🥳
| jobs: | ||
| - template: /eng/pipeline.yml@self | ||
| parameters: | ||
| ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}: |
Member
There was a problem hiding this comment.
Since we’ve separated the public/internal YAML files, we can remove these conditionals throughout this file as well as any others for conditionals that are checking internal vs. public to make things more readable.
The same can be applied to the files you duplicated e.g. azure-pipelines-pr.yml but feel free to do that in a separate PR if not already done.
Contributor
There was a problem hiding this comment.
Sure, I'll make the required changes and will create a separate PR regarding it.
lonitra
reviewed
Mar 14, 2024
rchauhan18
approved these changes
Mar 15, 2024
This was referenced Mar 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: dotnet/winforms#10895
Microsoft Reviewers: Open in CodeFlow
test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2404086&view=results
Build pipeline for PR doesn't use
azure-pipelines.yml, it usesazure-pipelines-pr.yml