Skip to content

Making resources in parity with WinUI #9151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2024
Merged

Making resources in parity with WinUI #9151

merged 1 commit into from
Jun 6, 2024

Conversation

@himgoyalmicro
Copy link
Contributor

@himgoyalmicro himgoyalmicro commented May 23, 2024 •
edited by dotnet-policy-service bot
Loading

Description

To make the colors and brushes more alinged with the WinUI one we have made the following changes:

  1. Moved some brushes from accent.xaml file to each theme file.
  2. Added some brushes in Light.xaml and dark.xaml
  3. Changed the color code of TextOnAccentFillColorDisabled and ControlAltFillColorTertiary
Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label May 23, 2024
@himgoyalmicro himgoyalmicro marked this pull request as ready for review May 23, 2024 07:49
@himgoyalmicro himgoyalmicro requested a review from a team as a code owner May 23, 2024 07:49
anjaligupta-dev
anjaligupta-dev approved these changes May 24, 2024
View reviewed changes
Copy link

@anjaligupta-dev anjaligupta-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@anjaligupta-dev anjaligupta-dev merged commit c64dc61 into dotnet:main Jun 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

1 more reviewer

@anjaligupta-dev anjaligupta-dev anjaligupta-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@himgoyalmicro himgoyalmicro

Labels

PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@himgoyalmicro @anjaligupta-dev