Add TargetName to Button's Trigger #9179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to missing
TargetNameproperty in various triggers of default button styles in Fluent window, there were visible discrepancies in UI when background property was set. The following changes adds the property and applies theBackgroundandBorderBrushproperty specifically to the border enclosing the content presenter.Customer Impact
It fixes the accessibility issues with hover and pressed states of a button, when
BackgroundorBorderBrushproperty is set at the application level.Testing
Local Build Pass
Sample Application Testing
Risk
None
Microsoft Reviewers: Open in CodeFlow