Replace ArrayList in CursorConverter with preallocated array and reduce allocations #9222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
PR
lindexi
reviewed
Jun 7, 2024
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/CursorConverter.cs
Show resolved
Hide resolved
h3xds1nz
changed the title
siagupta0202
approved these changes
Sep 10, 2024
harshit7962
added
Included in test pass
Status:Committed
and removed
Queue for test pass
Status:Proposed
labels
Member
|
@h3xds1nz Thank you for your contributions. |
Member
Author
|
@harshit7962 Thanks for including them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimizes
GetStandardValuesfunction from TypeConverter by replacingArrayListwith preallocated array as we know the size beforehand, removes unnecessary allocations caused by copying the list and re-allocating the internal array.Removes the private helper function
GetPropertiesthat's only used in 1 place, inlining it instead.Customer Impact
Improved performance, reduced allocations.
Regression
No.
Testing
Method functionality test, build.
Risk
None.
Microsoft Reviewers: Open in CodeFlow