Skip to content

Conversation

@dipeshmsft
Copy link
Member

@dipeshmsft dipeshmsft commented Jun 26, 2024

Description

In this PR, I have added a simple PS script to combine all the Fluent theme XAML files into one. I have also removed some duplicate keys from the XAML files for this.

The ThemeGenerator.Fluent script unlike the previous script does not provide many functionalities ( like optimizing keys, and checking for DynamicResource references ) . It is a very simple script at the moment but depending on the necessities, we will keep adding features to this.

There is a reference to this task in : #8991

Customer Impact

Instead of loading multiple merged ResourceDictionaries, developer will load a single large ResourceDictionary which will help boost performance.

Regression

N/A

Testing

Yet to be done.

Risk

N/A

Microsoft Reviewers: Open in CodeFlow

@dipeshmsft dipeshmsft requested review from a team as code owners June 26, 2024 06:17
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 26, 2024
@lindexi
Copy link
Member

lindexi commented Jun 26, 2024

This reminds me of @batzen 's XAMLTools, which can combine the XAML.

@dipeshmsft
Copy link
Member Author

This reminds me of @batzen 's XAMLTools, which can combine the XAML.

That is a much-advanced version of this script 😄

@dipeshmsft
Copy link
Member Author

Closing this in favor of #9422

@dipeshmsft dipeshmsft closed this Jul 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
@dipeshmsft dipeshmsft deleted the fluent/theme-generator branch August 29, 2024 08:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants