Skip to content

Conversation

@himgoyalmicro
Copy link
Contributor

@himgoyalmicro himgoyalmicro commented Jun 28, 2024

Description

Addressing following issues:

  1. Keyboard focus is not visible on the data cells in the table of the data grid page in High Contrast Desert mode.
  2. Keyboard focus is not visible on the buttons in High Contrast Desert mode.
  3. Keyboard focus faintly visible on the interactive controls of the application in High Contrast Aquatic mode.
  4. Keyboard focus on the expander is not visible in Aquatic mode and faintly visible in Desert mode.
  5. Selected/Focused list items in the List Box are not clearly visible in High Contrast Aquatic and Desert modes.
  6. Selected "Month/Year" are not clearly visible in the High Contrast Aquatic/Desert mode.

Made the following changes:

  1. Changed the KeyboardFocusBorderColor, CalendarViewItemBackgroundPointerOver and CalendarViewSelectedBackground values in High Contrast themes
  2. Changed the ListBoxItemSelectedForegroundThemeBrush in the Light and Dark themes
  3. Added explicit focus visual style to Button, ComboBox and DataGridCell
  4. Updated the focus visual style of Expander
  5. Added a Foreground property to ListBoxItem on Selected State

Customer Impact

Users relying on the High Contrast modes will be impacted if the elements are not clearly visible in High Contrast modes.

Regression

None

Testing

Local build passed, tested sample app.

Risk

NA

Microsoft Reviewers: Open in CodeFlow

1. Changed the KeyboardFocusBorderColor, CalendarViewItemBackgroundPointerOver and CalendarViewSelectedBackground values in High Contrast themes
2. Changed the ListBoxItemSelectedForegroundThemeBrush in the Light and Dark themes
3. Added explicit focus visual style to Button, ComboBox and DataGridCell
4. Updated the focus visual style of Expander
5. Added a Foreground property to ListBoxItem on Selected State
@himgoyalmicro himgoyalmicro self-assigned this Jun 28, 2024
@himgoyalmicro himgoyalmicro requested review from a team as code owners June 28, 2024 07:46
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 28, 2024
@dipeshmsft dipeshmsft merged commit 0628a77 into dotnet:main Jul 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants